Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dependencies referenced by posthtml-include #1355

Merged
merged 2 commits into from
May 22, 2018

Conversation

jdanyow
Copy link
Contributor

@jdanyow jdanyow commented May 13, 2018

fixes #488
closes #1226

🚨 note: works with config like this:

module.exports = {
plugins: {
"posthtml-include": {
root: __dirname
}
}
};

not like this:

module.exports = {
plugins: [
require('posthtml-include')({
root: __dirname
})
]
};

@jdanyow jdanyow mentioned this pull request May 15, 2018
@jdanyow jdanyow force-pushed the posthtml-include branch 2 times, most recently from 46ee34c to 0daf85d Compare May 20, 2018 04:11
@devongovett
Copy link
Member

What do you think about making this less specific to posthtml-include? Could we just pass this function to all posthtml plugins?

@jdanyow
Copy link
Contributor Author

jdanyow commented May 21, 2018

Sounds good to me, I've update the PR.

@devongovett
Copy link
Member

cool, looks like the test is failing though

@jdanyow
Copy link
Contributor Author

jdanyow commented May 21, 2018

hmm- will rebase and try again... passing for me locally.

@jdanyow
Copy link
Contributor Author

jdanyow commented May 21, 2018

ok rebased- it's passing now. There's a vue test that's failing though: "should produce a vue bundle using preprocessors". I think it broke in #1375

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🙋 Watch pre-transform HTML files
2 participants