Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added version option to command description #147

Merged
merged 2 commits into from
Dec 11, 2017
Merged

added version option to command description #147

merged 2 commits into from
Dec 11, 2017

Conversation

philipodev
Copy link
Contributor

Hi, awesome project you got there.

Noticed, when looking for it, there's no description in --help how to output the current version so i added it.

Copy link
Contributor

@yeskunall yeskunall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't think this is needed. commander handles this for you.

EDIT: Looks like parcel is overriding the automated help. My bad. However, you can avoid repeating yourself by just adding that under the help section.

@philipodev
Copy link
Contributor Author

@yeskunall hmm, you're right. no point in having the description in anything other than --help. i have commited changes for this. thanks

@devongovett
Copy link
Member

parcel --version already works.

@devongovett devongovett closed this Dec 9, 2017
@philipodev
Copy link
Contributor Author

@devongovett yes it does, but this PR simply adds it to the --help. I was personally looking for it when -v (lowercase) didn't work.

@jamiebuilds jamiebuilds reopened this Dec 9, 2017
@yeskunall
Copy link
Contributor

@philipodev with your current changes, won't this only work for the serve command? I'm just curious 😅

@philipodev
Copy link
Contributor Author

@yeskunall yes, but parcel is using that command as --help. But if you type parcel watch --help you get the help for watch command and then I don't think printing the version option is relevant. :)

@devongovett devongovett merged commit 35c65a3 into parcel-bundler:master Dec 11, 2017
rakannimer pushed a commit to rakannimer/parcel that referenced this pull request Dec 11, 2017
* added version option to command description

* remove unneccessary descriptions
devongovett pushed a commit that referenced this pull request Oct 15, 2018
* added version option to command description

* remove unneccessary descriptions
devongovett pushed a commit that referenced this pull request Oct 15, 2018
* added version option to command description

* remove unneccessary descriptions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants