Fix duplicated content due to symlinks

[padmaia]

fixes #1125

[codecov-io]

Codecov Report

Merging #1505 into master will decrease coverage by 0.99%.
The diff coverage is 83.33%.

@@           Coverage Diff           @@
##           master    #1505   +/-   ##
=======================================
- Coverage   89.21%   88.22%   -1%     
=======================================
  Files          80       80           
  Lines        4403     4406    +3     
=======================================
- Hits         3928     3887   -41     
- Misses        475      519   +44

Impacted Files	Coverage Δ
src/Resolver.js	100% <100%> (ø)	⬆️
src/Bundler.js	93.18% <75%> (-0.25%)	⬇️
src/transforms/htmlnano.js	68.42% <0%> (-31.58%)	⬇️
src/utils/loadPlugins.js	64.28% <0%> (-26.2%)	⬇️
src/transforms/posthtml.js	84.21% <0%> (-12.29%)	⬇️
src/visitors/dependencies.js	78.63% <0%> (-6.84%)	⬇️
src/utils/localRequire.js	94.11% <0%> (-5.89%)	⬇️
src/utils/config.js	86.95% <0%> (-4.35%)	⬇️
src/utils/getTargetEngines.js	94.73% <0%> (-2.11%)	⬇️
src/visitors/fs.js	91.24% <0%> (-1.46%)	⬇️
... and 2 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40fb76f...84788c4. Read the comment docs.

[devongovett]

Thanks! I think we'll probably need to also store the realpath in the cache instead of (along with?) the symlink path so that the assets get deduped in subsequent builds. See https://github.com/parcel-bundler/parcel/pull/1505/files#diff-ed26e1346331966874d8103cdcdbed47R416

[padmaia]

Yeah, I'm realizing I was too zoomed in on this. I'll spend some more time on it this week.

[padmaia]

I'm going to close this PR because based on my findings outlined in this comment I don't think the related issue should be considered a bug to be fixed. If we decide to add an option to accommodate normal Node module resolution I will open up another PR.