Fix babel config in package.json #1515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Babel seems to mutate the passed-in config, so if we pass in the package.babel directly it will mutate the package config, then the next time it compiles the same file it will have duplicate plugins, etc. Instead, if loading config from a packageKey, clone the config before returning so it can't be mutated.
DeMoorJasper
approved these changes
Jun 9, 2018
Codecov Report
@@ Coverage Diff @@
## master #1515 +/- ##
==========================================
- Coverage 89.21% 88.99% -0.23%
==========================================
Files 80 80
Lines 4403 4660 +257
==========================================
+ Hits 3928 4147 +219
- Misses 475 513 +38
Continue to review full report at Codecov.
|
|
So quick! Thanks. 🙇🏻♂️ |
devongovett
pushed a commit
that referenced
this pull request
Oct 15, 2018
Babel seems to mutate the passed-in config, so if we pass in the package.babel directly it will mutate the package config, then the next time it compiles the same file it will have duplicate plugins, etc. Instead, if loading config from a packageKey, clone the config before returning so it can't be mutated.
devongovett
pushed a commit
that referenced
this pull request
Oct 15, 2018
Babel seems to mutate the passed-in config, so if we pass in the package.babel directly it will mutate the package config, then the next time it compiles the same file it will have duplicate plugins, etc. Instead, if loading config from a packageKey, clone the config before returning so it can't be mutated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I figured out #927.
Babel seems to mutate config. More specifically, presets seem to append plugins every time babel is run. Because the asset caches
asset.package, when using a package config likeasset.package.babel, babel mutates the cached package config. Next time it needs the config it gets the same config, and mutates it again.Instead, if loading config using a packageKey, clone the config before returning so mutations won't be persisted on the cached copy.