Prevent circular deps from causing a stack overflow in HMR runtime #2660
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
↪️ Pull Request
This PR prevents a stack overflow when updating files that have circular dependencies. This issue occurs when HMR tries to reload dependencies and gets stuck following the loop. The fix is achieved by adding a set that contains each of the asset ID updated in the same HMR update event. This set is used to keep track of what has been updated and skips loading the same asset more than once.
Fixes #1192