Conserve the html spacing between tags #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandon93s
approved these changes
Dec 22, 2017
brandon93s
reviewed
Dec 22, 2017
| @@ -11,5 +11,6 @@ <h1>Hello world</h1> | |||
| <a href="tel:+33636757575">Tel link</a> | |||
| <script src="index.js"></script> | |||
| <script src="https://unpkg.com/parcel-bundler"></script> | |||
| <i>hello</i> <i>world</i> | |||
There was a problem hiding this comment.
To elaborate on this scenario, since you wouldn't write the above html in practice, consider the following:
<div>
<span class="a">Hello in style a</span> <span class="b">World in style b</span>
</div>There was a problem hiding this comment.
@brandon93s Should I update my PR ? Or is this just for info ?
There was a problem hiding this comment.
Just info for reviewers.
There was a problem hiding this comment.
hmm, wonder why this is the default behavior for htmlnano? should bring this up with them?
devongovett
pushed a commit
that referenced
this pull request
Oct 15, 2018
devongovett
pushed a commit
that referenced
this pull request
Oct 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#372
Currently, HTML minification strips the space between two tags. The result might become "helloworld"
This PR would prevent that from happening.