Insert sibling bundles before main script with almost empty html #4456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mischnic
requested review from
devongovett,
wbinnssmith,
DeMoorJasper and
padmaia
|
mischnic
force-pushed
the
html-insert-sibling-order
branch
2 times, most recently
from
cc02ce5 to
9af55fb
Compare
mischnic
force-pushed
the
html-insert-sibling-order
branch
from
9af55fb to
b4fce5a
Compare
Benchmark ResultsKitchen Sink ✅
Timings
Cold Bundles
Cached Bundles
React HackerNews ✅
Timings
Cold Bundles
Cached Bundles
AtlasKit Editor ✅
Timings
Cold Bundles
Cached Bundles
Three.js x4 🚨
Timings
Cold BundlesNo bundles found, this is probably a failed build... Cached BundlesNo bundles found, this is probably a failed build... |
wbinnssmith
approved these changes
Apr 9, 2020
mischnic
commented
Apr 9, 2020
| assert( | ||
| /<\/script>\s*<link rel="stylesheet" href="[/\\]{1}html-css-optional-elements\.[a-f0-9]+\.css"><h1>Hello/.test( | ||
| /^<link rel="stylesheet" href="[/\\]html-css-optional-elements\.[a-f0-9]+\.css">\s*<script src="[/\\]other\.[a-f0-9]+\.js"><\/script>\s*<h1>Hello/m.test( |
There was a problem hiding this comment.
My change is to insert the sibling before the first non-metadata tag or script.
So previously
<script src="/other.7576ab85.js"></script> <!-- entry1-->
<link rel="stylesheet" href="/html-css-optional-elements.03af036d.css"> <!-- inserted -->
<h1>Hello world</h1>
<script src="/html-css-optional-elements.9d40fb57.js"></script> <!-- entry2 -->Now:
<link rel="stylesheet" href="/html-css-optional-elements.03af036d.css"> <!-- inserted -->
<script src="/other.7576ab85.js"></script> <!-- entry1 -->
<h1>Hello world</h1>
<script src="/html-css-optional-elements.9d40fb57.js"></script> <!-- entry2 -->I guess this is fine?
To keep the old behaviour we would need to have a different logic when a link (order doesn't matter) or a script (order is important) is inserted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
↪️ Pull Request
The sibling script could be inserted after the first script, meaning after the entry bundle
Likely a regression from #4306
Part of #4389