feat(hmr-ws-port): adds ability to explicitly set hmr ws port #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devongovett
requested changes
Jan 1, 2018
src/cli.js
Outdated
| @@ -13,6 +13,11 @@ program | |||
| 'set the port to serve on. defaults to 1234', | |||
| parseInt | |||
| ) | |||
| .option( | |||
| '-w, --websocket-port <port>', | |||
There was a problem hiding this comment.
can we call the option --hmr-port so it's clear what websocket is being referred to?
There was a problem hiding this comment.
yeah, do you want it to be -h, --hmr-port?
src/HMRServer.js
Outdated
| @@ -2,9 +2,9 @@ const WebSocket = require('ws'); | |||
| const prettyError = require('./utils/prettyError'); | |||
|
|
|||
| class HMRServer { | |||
| async start() { | |||
| async start(websockerPort) { | |||
There was a problem hiding this comment.
misspelled. just call it port.
devongovett
approved these changes
Jan 1, 2018
devongovett
pushed a commit
that referenced
this pull request
Oct 15, 2018
* feat(hmr-ws-port): adds ability to explicitly set hmr ws port * fix(conflict): fix merge conflict * fix(hmr-ws-port): change args, misc cleanup * fix(hmr-ws-port): add args to cli
devongovett
pushed a commit
that referenced
this pull request
Oct 15, 2018
* feat(hmr-ws-port): adds ability to explicitly set hmr ws port * fix(conflict): fix merge conflict * fix(hmr-ws-port): change args, misc cleanup * fix(hmr-ws-port): add args to cli
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to address issues from #279 in allowing a specific port to be set for the HMR websocket. This allows the use, either in containers, behind firewalls, or in other circumstances where allowing broad port access is not viable, to specifically set the port:
Ensured non-breaking by defaulting to
0as was previously hard-coded into the WS and HMR configuration.