Pass configs as paths instead of objects #4927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a cli option to specify which config to use
|
padmaia
commented
Jul 23, 2020
Benchmark ResultsKitchen Sink ✅
Timings
Cold Bundles
Cached Bundles
React HackerNews ✅
Timings
Cold Bundles
Cached Bundles
AtlasKit Editor ✅
Timings
Cold Bundles
Cached Bundles
Three.js x4 🚨
Timings
Cold BundlesNo bundles found, this is probably a failed build... Cached BundlesNo bundles found, this is probably a failed build... |
padmaia
force-pushed
the
config-specification-api
branch
2 times, most recently
from
0715951 to
a879936
Compare
wbinnssmith
approved these changes
Sep 9, 2020
3 tasks
|
@padmaia Hmm, is dropping support for programmatically passing config objects intentional? I'm giving Parcel v2 a spin trying it to upgrade an old (but relatively complex) build pipeline, and would like to pass a bunch of state known when creating the Parcel instance to a custom babel transform. Seems quite a waste (if not impossible?) to re-figure out these parameters in the transform. (But I've just started looking into Parcel, so let me know if it has a very good reason to only support paths, eg perhaps they serialize better than closures when passing to workers or so). |
Very surprised to see this removed as well! Programmatically defining a config should be an option like all other bundlers here that offer a programmatic API. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
↪️ Pull Request
Also adds a cli option to specify which config to use
✔️ PR Todo