Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use require.resolve when resolving default config #5127

Merged
merged 8 commits into from
Sep 18, 2020
Merged

fix: use require.resolve when resolving default config #5127

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
c97bb1e
fix: use require.resolve when resolving default config
paul-soporan Sep 10, 2020
ed60304
Merge branch 'v2' into fix/default-config-resolving
paul-soporan Sep 11, 2020
32b193e
refactor: look in cwd first when resolving the default config
paul-soporan Sep 11, 2020
985a894
chore: add $FlowFixMe
paul-soporan Sep 11, 2020
e015449
style: run prettier
paul-soporan Sep 11, 2020
3fbb491
Merge branch 'v2' into fix/default-config-resolving
mischnic Sep 14, 2020
3210e82
Merge branch 'v2' into fix/default-config-resolving
paul-soporan Sep 18, 2020
0ab8851
Merge branch 'v2' into fix/default-config-resolving
mischnic Sep 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions packages/core/parcel/src/cli.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,11 +179,15 @@ async function run(entries: Array<string>, command: any) {
}
let Parcel = require('@parcel/core').default;
let options = await normalizeOptions(command);
let packageManager = new NodePackageManager(new NodeFS());
let fs = new NodeFS();
let packageManager = new NodePackageManager(fs);
let parcel = new Parcel({
entries,
packageManager,
defaultConfig: '@parcel/config-default',
// $FlowFixMe - flow doesn't know about the `paths` option (added in Node v8.9.0)
defaultConfig: require.resolve('@parcel/config-default', {
paths: [fs.cwd(), __dirname],
}),
patchConsole: true,
...options,
});
Expand Down