Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: serve static files that exist in the outDir even when they don't… #536

Closed
wants to merge 2 commits into from
Closed

Fix: serve static files that exist in the outDir even when they don't… #536

wants to merge 2 commits into from

Conversation

naturalethic
Copy link

… begin with the publicUrl (#303)

@codecov-io
Copy link

codecov-io commented Jan 11, 2018

Codecov Report

Merging #536 into master will decrease coverage by 1.93%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #536      +/-   ##
==========================================
- Coverage   89.06%   87.13%   -1.94%     
==========================================
  Files          68       68              
  Lines        3438     3435       -3     
==========================================
- Hits         3062     2993      -69     
- Misses        376      442      +66
Impacted Files Coverage Δ
src/Server.js 94.33% <100%> (+2.67%) ⬆️
src/assets/GlobAsset.js 58.66% <0%> (-40%) ⬇️
src/assets/CSSAsset.js 68.69% <0%> (-21.74%) ⬇️
src/assets/JSONAsset.js 84.61% <0%> (-7.7%) ⬇️
src/visitors/dependencies.js 81.81% <0%> (-5.2%) ⬇️
src/utils/getTargetEngines.js 93.25% <0%> (-3.38%) ⬇️
src/utils/installPackage.js 61.9% <0%> (-3.18%) ⬇️
src/assets/JSAsset.js 90.83% <0%> (-0.77%) ⬇️
src/visitors/fs.js 56.94% <0%> (-0.7%) ⬇️
src/assets/GraphqlAsset.js 100% <0%> (ø) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c469751...2d09557. Read the comment docs.

@sompylasar
Copy link

@naturalethic Hi, could you please update this PR to resolve the conflict?
@DeMoorJasper Hi, what's blocking this besides the merge conflict?

Thanks!

@devongovett
Copy link
Member

Going to close this. I think it has been resolved in the meantime. I'm not sure how files would get into the outDir that parcel didn't generate the URL for.

@devongovett devongovett closed this Jul 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants