Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend test utils to execute ESM bundles #5548

Merged
merged 2 commits into from
Jan 21, 2021
Merged

Extend test utils to execute ESM bundles #5548

merged 2 commits into from
Jan 21, 2021

Conversation

mischnic
Copy link
Member

@mischnic mischnic commented Dec 30, 2020 •
edited
Loading

  1. Execute the ESM build output and compares it with the expected result
  2. Where possible (= if there's no CJS interop problem), compare the exports of the build output with the exports of the build input

Depends on #5664

Close T-461

TODO:

  • update assertions
  • Not include require in the context for Node with esm

@height
Copy link

height bot commented Dec 30, 2020 •
edited
Loading

This pull request has been linked to and will mark 1 task as "Done" when merged:

💡Tip: You can link multiple Height tasks to a pull request.

@parcel-benchmark
Copy link

parcel-benchmark commented Dec 30, 2020 •
edited
Loading

Benchmark Results

Kitchen Sink ✅

Timings

Description Time Difference
Cold 2.62s -32.00ms
Cached 522.00ms +10.00ms

Cold Bundles

Bundle Size Difference Time Difference
dist/legacy/parcel.d5807e82.webp 102.94kb +0.00b 547.00ms -60.00ms 🚀
dist/modern/parcel.d5807e82.webp 102.94kb +0.00b 517.00ms +37.00ms ⚠️
dist/legacy/index.9ff7c523.js 1.11kb +0.00b 556.00ms -59.00ms 🚀
dist/modern/index.f81b5b4b.js 1.11kb +0.00b 545.00ms +45.00ms ⚠️
dist/legacy/index.html 701.00b +0.00b 549.00ms -66.00ms 🚀
dist/modern/index.html 701.00b +0.00b 545.00ms +45.00ms ⚠️
dist/legacy/index.5859ab37.css 77.00b +0.00b 849.00ms -86.00ms 🚀
dist/modern/index.77ce15d4.css 77.00b +0.00b 905.00ms +82.00ms ⚠️

Cached Bundles

Bundle Size Difference Time Difference
dist/modern/parcel.d5807e82.webp 102.94kb +0.00b 52.00ms -20.00ms 🚀
dist/legacy/index.9ff7c523.js 1.11kb +0.00b 53.00ms -20.00ms 🚀
dist/modern/index.f81b5b4b.js 1.11kb +0.00b 53.00ms -19.00ms 🚀
dist/legacy/index.html 701.00b +0.00b 56.00ms +4.00ms ⚠️
dist/modern/index.html 701.00b +0.00b 53.00ms -20.00ms 🚀
dist/modern/index.77ce15d4.css 77.00b +0.00b 53.00ms -19.00ms 🚀

React HackerNews ✅

Timings

Description Time Difference
Cold 16.82s -969.00ms 🚀
Cached 7.74s +169.00ms

Cold Bundles

Bundle Size Difference Time Difference
dist/PermalinkedComment.1964b8bb.js 4.20kb +0.00b 604.00ms -254.00ms 🚀
dist/UserProfile.f5fa9f60.js 1.76kb +0.00b 604.00ms -254.00ms 🚀
dist/NotFound.f4adce8d.js 530.00b +0.00b 216.00ms +13.00ms ⚠️
dist/logo.24c8bf9e.png 274.00b +0.00b 434.00ms -22.00ms 🚀

Cached Bundles

Bundle Size Difference Time Difference
dist/PermalinkedComment.1964b8bb.js 4.20kb +0.00b 68.00ms +4.00ms ⚠️
dist/UserProfile.f5fa9f60.js 1.76kb +0.00b 68.00ms +4.00ms ⚠️
dist/NotFound.f4adce8d.js 530.00b +0.00b 39.00ms +2.00ms ⚠️
dist/logo.24c8bf9e.png 274.00b +0.00b 55.00ms +8.00ms ⚠️

AtlasKit Editor ✅

Timings

Description Time Difference
Cold 1.71m -208.00ms
Cached 2.52s -197.00ms 🚀

Cold Bundles

Bundle Size Difference Time Difference
dist/index.49febfe6.js 2.46mb +10.00b ⚠️ 55.44s -948.00ms
dist/pdfRenderer.1c87caa3.js 1.11mb +0.00b 31.14s -2.29s 🚀
dist/editorView.94307fd1.js 587.53kb +0.00b 43.82s -2.25s 🚀
dist/Toolbar.453ced4a.js 99.77kb +0.00b 12.32s -1.12s 🚀
dist/media-viewer.b4647ff4.js 72.87kb +0.00b 8.64s -989.00ms 🚀
dist/card.92b0f4f9.js 54.02kb +0.00b 6.64s -568.00ms 🚀
dist/card.43bef276.js 51.77kb +0.00b 10.62s -1.05s 🚀
dist/Modal.507a0880.js 39.18kb +0.00b 3.05s -622.00ms 🚀
dist/component.e862677c.js 30.82kb +0.00b 3.13s +1.47s ⚠️
dist/esm.572878ca.js 27.67kb +0.00b 8.61s +2.59s ⚠️
dist/component.c1c3a8ff.js 22.54kb +0.00b 3.05s -201.00ms 🚀
dist/DatePicker.64b5aa93.js 21.20kb +0.00b 4.34s -1.21s 🚀
dist/smartMediaEditor.ab51c6dd.js 16.85kb +0.00b 12.20s -1.15s 🚀
dist/js.63570256.js 16.55kb +0.00b 3.04s -211.00ms 🚀
dist/dropzone.491f3481.js 16.06kb +0.00b 13.06s +2.14s ⚠️
dist/ui.bfd5ec70.js 14.21kb +0.00b 6.43s -600.00ms 🚀
dist/workerHasher.c27b76fd.js 11.90kb +0.00b 4.89s -3.64s 🚀
dist/card.89465567.js 5.71kb +0.00b 6.46s -3.16s 🚀
dist/media-viewer.114c1cc8.js 4.01kb +0.00b 8.62s -1.33s 🚀
dist/EmojiPickerComponent.5d345edd.js 3.62kb +0.00b 4.90s -3.59s 🚀
dist/png-chunks-extract.8c8d635d.js 3.55kb +0.00b 3.04s -211.00ms 🚀
dist/index.10f02a5e.css 3.46kb +0.00b 31.68s -1.74s 🚀
dist/Modal.19c70720.js 3.14kb +0.00b 891.00ms -2.49s 🚀
dist/clipboard.84ebdbd2.js 2.97kb +0.00b 10.37s -944.00ms 🚀
dist/16.624bbe22.js 2.49kb +0.00b 872.00ms -781.00ms 🚀
dist/ResourcedEmojiComponent.470ee09d.js 2.15kb +0.00b 4.90s -2.13s 🚀
dist/card.4188bb6a.js 2.15kb +0.00b 8.63s -1.65s 🚀
dist/date.57372c70.js 1.96kb +0.00b 3.46s -740.00ms 🚀
dist/images.c36248a4.js 1.90kb +0.00b 3.64s -219.00ms 🚀
dist/feedback.80c8a178.js 1.86kb +0.00b 7.82s +2.27s ⚠️
dist/16.342e69d2.js 1.86kb +0.00b 3.35s -238.00ms 🚀
dist/browser.00e50e54.js 1.82kb +0.00b 10.37s -1.16s 🚀
dist/16.d173f3df.js 1.79kb +0.00b 3.21s -192.00ms 🚀
dist/workerHasher.f1855576.js 1.75kb +0.00b 4.89s -681.00ms 🚀
dist/workerHasher.cbff2c2b.js 1.75kb +0.00b 13.18s -690.00ms 🚀
dist/list-number.9bb92c49.js 1.68kb +0.00b 3.86s -537.00ms 🚀
dist/status.acecc9f0.js 1.68kb +0.00b 3.81s -295.00ms 🚀
dist/code.6d1ec8ce.js 1.61kb +0.00b 3.46s -276.00ms 🚀
dist/link.cda9435d.js 1.53kb +0.00b 3.86s -537.00ms 🚀
dist/16.9e858e4a.js 1.51kb +0.00b 3.50s -322.00ms 🚀
dist/16.adfefbb7.js 1.46kb +0.00b 3.21s -186.00ms 🚀
dist/16.23a6fba4.js 1.46kb +0.00b 3.21s -195.00ms 🚀
dist/emoji.5072e4af.js 1.45kb +0.00b 3.56s -289.00ms 🚀
dist/16.186663a4.js 1.45kb +0.00b 872.00ms -782.00ms 🚀
dist/16.2c3c2005.js 1.44kb +0.00b 3.46s -267.00ms 🚀
dist/expand.739e3b88.js 1.38kb +0.00b 7.82s +2.28s ⚠️
dist/16.8ff06a1d.js 1.36kb +0.00b 3.35s -238.00ms 🚀
dist/16.263c691c.js 1.34kb +0.00b 872.00ms -781.00ms 🚀
dist/heading2.5c4ee285.js 1.33kb +0.00b 3.88s -321.00ms 🚀
dist/16.b7512655.js 1.32kb +0.00b 3.36s -228.00ms 🚀
dist/16.262b91f7.js 1.31kb +0.00b 3.46s -266.00ms 🚀
dist/mention.76dc783a.js 1.29kb +0.00b 3.68s -294.00ms 🚀
dist/Modal.d58fb436.js 1.28kb +0.00b 3.04s -211.00ms 🚀
dist/16.436e2680.js 1.27kb +0.00b 872.00ms -781.00ms 🚀
dist/layout.d9b11ad1.js 1.27kb +0.00b 3.58s -277.00ms 🚀
dist/16.eaa9cadb.js 1.27kb +0.00b 3.35s -238.00ms 🚀
dist/16.06e8a68f.js 1.26kb +0.00b 3.21s -185.00ms 🚀
dist/16.19a76383.js 1.26kb +0.00b 3.50s -322.00ms 🚀
dist/16.e5432caf.js 1.26kb +0.00b 3.55s -276.00ms 🚀
dist/16.62eaafc3.js 1.26kb +0.00b 3.21s -186.00ms 🚀
dist/divider.2e62a51b.js 1.25kb +0.00b 3.56s -289.00ms 🚀
dist/quote.487996a9.js 1.25kb +0.00b 3.81s -295.00ms 🚀
dist/component.3edf7abd.js 1.23kb +0.00b 3.10s -278.00ms 🚀
dist/action.8161ba48.js 1.23kb +0.00b 3.46s -275.00ms 🚀
dist/16.0629cb86.js 1.23kb +0.00b 3.10s -278.00ms 🚀
dist/media-card-analytics-error-boundary.3d09fdec.js 1.23kb +0.00b 6.44s -899.00ms 🚀
dist/decision.cdcb6e3b.js 1.21kb +0.00b 3.55s -296.00ms 🚀
dist/panel-warning.8b68f633.js 1.21kb +0.00b 3.76s -220.00ms 🚀
dist/16.cd483156.js 1.18kb +0.00b 3.36s -238.00ms 🚀
dist/list.e0e1a7a9.js 1.18kb +0.00b 3.93s -465.00ms 🚀
dist/panel-error.210bc7a0.js 1.11kb +0.00b 3.68s -294.00ms 🚀
dist/panel.8b5546b1.js 1.10kb +0.00b 3.81s -295.00ms 🚀
dist/table.4e67906a.js 1.09kb +0.00b 3.82s -296.00ms 🚀
dist/panel-success.a2e1eac9.js 1.05kb +0.00b 3.69s -286.00ms 🚀
dist/panel-note.8e008c33.js 1.05kb +0.00b 3.68s -294.00ms 🚀
dist/media-picker-analytics-error-boundary.a20da0c5.js 1003.00b +0.00b 13.04s +2.57s ⚠️
dist/media-card-analytics-error-boundary.ef6306e0.js 999.00b +0.00b 6.43s -617.00ms 🚀
dist/media-card-analytics-error-boundary.889a764d.js 999.00b +0.00b 10.39s -3.45s 🚀
dist/media-viewer-analytics-error-boundary.880deb8d.js 995.00b +0.00b 8.63s -1.40s 🚀
dist/simpleHasher.d91ba9fe.js 755.00b +0.00b 4.89s -3.61s 🚀
dist/simpleHasher.b4d19bac.js 755.00b +0.00b 12.19s -1.71s 🚀
dist/index.html 119.00b +0.00b 2.42s +853.00ms ⚠️

Cached Bundles

Bundle Size Difference Time Difference
dist/Modal.148d3acc.js 39.01kb +0.00b 449.00ms -28.00ms 🚀
dist/component.e862677c.js 30.82kb +0.00b 443.00ms -34.00ms 🚀
dist/component.c1c3a8ff.js 22.54kb +0.00b 449.00ms -45.00ms 🚀
dist/js.63570256.js 16.55kb +0.00b 449.00ms -45.00ms 🚀
dist/component.dd6e8cc9.js 6.20kb +0.00b 458.00ms -36.00ms 🚀
dist/png-chunks-extract.8c8d635d.js 3.55kb +0.00b 449.00ms -45.00ms 🚀
dist/16.624bbe22.js 2.49kb +0.00b 442.00ms -36.00ms 🚀
dist/16.d173f3df.js 1.79kb +0.00b 458.00ms -29.00ms 🚀
dist/16.adfefbb7.js 1.46kb +0.00b 458.00ms -29.00ms 🚀
dist/16.186663a4.js 1.45kb +0.00b 443.00ms -34.00ms 🚀
dist/16.263c691c.js 1.34kb +0.00b 443.00ms -35.00ms 🚀
dist/Modal.d58fb436.js 1.28kb +0.00b 449.00ms -45.00ms 🚀
dist/16.436e2680.js 1.27kb +0.00b 443.00ms -34.00ms 🚀
dist/16.06e8a68f.js 1.26kb +0.00b 458.00ms -29.00ms 🚀
dist/16.62eaafc3.js 1.26kb +0.00b 458.00ms -29.00ms 🚀
dist/index.html 119.00b +0.00b 458.00ms +31.00ms ⚠️

Three.js ✅

Timings

Description Time Difference
Cold 11.81s -718.00ms 🚀
Cached 538.00ms -30.00ms 🚀

Cold Bundles

Bundle Size Difference Time Difference
dist/Three.js 580.59kb +0.00b 5.89s -309.00ms 🚀

Cached Bundles

Bundle Size Difference Time Difference
dist/Three.js 580.59kb +0.00b 90.00ms -5.00ms 🚀

Click here to view a detailed benchmark overview.

@mischnic mischnic mentioned this pull request Jan 1, 2021
Closed
@mischnic mischnic changed the base branch from v2 to esm-cross-bundle-interop January 15, 2021 14:43
@mischnic mischnic marked this pull request as ready for review January 15, 2021 14:52
Base automatically changed from esm-cross-bundle-interop to v2 January 21, 2021 20:48
@mischnic mischnic merged commit ac6a0cb into v2 Jan 21, 2021
@mischnic mischnic deleted the tests-run-esm branch January 21, 2021 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DeMoorJasper DeMoorJasper DeMoorJasper approved these changes

@devongovett devongovett Awaiting requested review from devongovett

@wbinnssmith wbinnssmith Awaiting requested review from wbinnssmith

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mischnic @parcel-benchmark @DeMoorJasper