Pass version to presetEnv

[bemnlam]

↪️ Pull Request

Fixing #5943

This change in babel breaks Parcel if version doesn't pass into presetEnv(). By setting version as 7.13.0 presetEnv() will continue other checking, just like the logic before.

[height]

Link Height tasks by mentioning a task ID in the pull request title or description, commit messages, or comments.

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

[devongovett]

I think this is a v1 only bug? This code path won't actually be hit in v2 because config.isSource is always true.

[nicolo-ribaudo]

Q: If that code path won't be hit, the code can just be deleted?

[nicolo-ribaudo]

This should be 7.12.0 (

parcel/packages/transformers/babel/package.json

Line 43 in 806cc65

"@babel/core": "^7.12.0"

), or require("@babel/core").version.

Ideally, the safest approach would be { ...require("@babel/core"), assertVersion: () => true }.

[mischnic]

Yes,

parcel/packages/transformers/babel/src/config.js

Lines 38 to 41 in 806cc65

	// Don't transpile inside node_modules
	if (!config.isSource) {
	return;
	}

means that this whole if statement could be removed because it's never reached if !config.isSource:

parcel/packages/transformers/babel/src/env.js

Lines 30 to 41 in 806cc65

	// If this is the app module, the source and target will be the same, so just compile everything.
	// Otherwise, load the source engines and generate a babel-present-env config.
	if (!config.isSource) {
	let sourceBabelTargets = await getBabelTargets(config);
	if (
	!sourceBabelTargets ||
	!shouldCompileFurther(sourceBabelTargets, appBabelTargets)
	) {
	return null;
	}
	}

[bemnlam]

@nicolo-ribaudo @mischnic so looks like this is a v1-only issue and what can I do if I also want to apply this change to v1? (sorry I am a newbie and I want to help 🙏)

[nicolo-ribaudo]

@bemnlam Parcel 1 is on the master branch, but I'd wait for the ok from a maintainer before opening a PR for Parcel 1.

[agilgur5]

@devongovett @mischnic could y'all review this change, particularly for v1? #5943 is being felt quite massively across the community as I'm sure you're seeing. I was going to write this PR myself (even though I'm only indirectly impacted) before finding it was already done here.

Currently, the only solution right now is either a resolution or a not-so-easy migration to the v2 beta -- this fix is considerably simpler than either.

[devongovett]

v1.12.5 has a fix. Please see #5943 (comment)