Worker bug fixes #6582
Merged
Worker bug fixes #6582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to and will mark 2 tasks as "Done" when merged:
|
Benchmark ResultsKitchen Sink 🚨
Timings
Cold BundlesNo bundles found, this is probably a failed build... Cached BundlesNo bundles found, this is probably a failed build... React HackerNews ✅
Timings
Cold Bundles
Cached Bundles
AtlasKit Editor 🚨
Timings
Cold BundlesNo bundles found, this is probably a failed build... Cached BundlesNo bundles found, this is probably a failed build... Three.js ✅
Timings
Cold BundlesNo bundle changes detected. Cached BundlesNo bundle changes detected. |
DeMoorJasper
approved these changes
Jul 12, 2021
wbinnssmith
reviewed
Jul 12, 2021
| let lodashSibling = path.basename( | ||
| b.getBundles().find(v => v.getEntryAssets().length === 0).filePath, | ||
| ); | ||
| // let lodashSibling = path.basename( |
There was a problem hiding this comment.
debug? or should this be removed?
There was a problem hiding this comment.
I left it in case we bring back shared bundles between page and worker...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6579. Fixes #5503. Fixes #5504. Fixes #5920. Fixes #5864. Fixes #6562. Fixes T-1102. Fixes T-1101.
importScriptswhich would previously error for modules.importbeing renamed to_importby SWC for very old browser targets (ES3 reserved words pass).new Worker('current-filename'). This was a bug in bundling that caused the asset to be erroneously internalized due to the cycle.