-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Readme.md: Make summary about parcel more accurate #6821
Conversation
`node_modules` can't be transpiled, see parcel-bundler#1655 and parcel-bundler#6306 (comment)
|
In case anyone wonders thanks to @mischnic I have the ultimate workaround. With a patch like this
(use resolutions in yarn berry and target And then you can force transpile things via an environment variable |
FWIW, Solid doesn't support IE11 anyway so not sure what good transpiling it will do https://github.com/solidjs/solid#browser-support |
@devongovett yeah, that's my next problem :( but I can deal with that from my javascript code and disable the solid-parts or just let it fail silently like it does WHEN the code runs. But if it has arrow functions it doesn't run at all so even my non-solid code can't do anything about it nor provide its functionality |
@devongovett also it, transpiled and with polyfills, works in for example firefox 48 which isn't officially supported. So why not support it when all I need for that is a little transpilation? |
I think we are probably going to change this we just haven't figured out exactly how it should work yet. I think only some syntax should be allowed, eg no non-standard stuff like JSX or TypeScript and no future JS proposals. |
Hahaha did building sentry with typescript as node_modules in #6176 feel so wrong? For my part I'd obviously appreciate if everything was supported because I need to find another way to build sentry otherwise but I totally understand it's strictly speaking "abuse" of what parcel as tool is intended to do.
But yeah, I totally agree. You need to solve it somehow, rather sooner than later, but it's a very difficult problem while maintaining a "zero-config" approach. Like, I don't even have any good ideas to solve it lol. But I'm sure you'll come up with something ingenious 👍 For now it's not supported tho, alas this PR. And also I really needed to get my stuff done today and not in a month which is why I had to figure out the patching. |
@devongovett FYI I got solid working in IE11 :dances furiously: |
The readme was rewritten in the meantime and that statement was removed |
btw I think you're still saying "including node modules" on opencollective https://opencollective.com/parcel
|
↪️ Pull Request
node_modules
can't be transpiled, see #1655 and #6306 (comment)Yet the readme claimed they could. I propose to remove that claim.
💻 Examples
Me right now that needs solid-js to not make my scripts throw syntax errors in older browsers because they contain arrow functions because parcel refuses to transpile them
🚨 Test instructions
Clone solid-js, import something from it, add something like this to package.json
and build -> you have arrow functions
✔️ PR Todo