Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require sharp from the main thread to prevent issues on worker exit #7001

Merged
merged 2 commits into from
Oct 1, 2021

Conversation

devongovett
Copy link
Member

Potentially fixes #5961

Sharp doesn't play nice with Node worker_threads, because on thread exit it may unload a shared library that is still being used. So this tries to require it from the main thread before using it in a worker. See https://sharp.pixelplumbing.com/install#worker-threads and lovell/sharp#2263

@height
Copy link

height bot commented Sep 30, 2021

Link Height tasks by mentioning a task ID in the pull request title or description, commit messages, or comments.

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Segmentation fault (core dumped)
1 participant