Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix serve mode with target override and target source fields #7187

Merged
merged 4 commits into from
Oct 31, 2021
Merged

Fix serve mode with target override and target source fields #7187

merged 4 commits into from
Oct 31, 2021

Conversation

mischnic
Copy link
Member

Closes #6905

@height
Copy link

height bot commented Oct 25, 2021

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@parcel-benchmark
Copy link

parcel-benchmark commented Oct 25, 2021 •
edited
Loading

Benchmark Results

Kitchen Sink ✅

Timings

Description Time Difference
Cold 2.45s -47.00ms
Cached 340.00ms -28.00ms 🚀

Cold Bundles

Bundle Size Difference Time Difference
dist/legacy/parcel.7cdb0fad.webp 102.94kb +0.00b 732.00ms -59.00ms 🚀
dist/legacy/parcel.7cdb0fad.webp 102.94kb +0.00b 733.00ms -59.00ms 🚀
dist/modern/parcel.7cdb0fad.webp 102.94kb +0.00b 733.00ms -58.00ms 🚀

Cached Bundles

Bundle Size Difference Time Difference
dist/legacy/parcel.7cdb0fad.webp 102.94kb +0.00b 792.00ms +63.00ms ⚠️
dist/legacy/parcel.7cdb0fad.webp 102.94kb +0.00b 793.00ms +64.00ms ⚠️
dist/modern/parcel.7cdb0fad.webp 102.94kb +0.00b 793.00ms +63.00ms ⚠️

React HackerNews ✅

Timings

Description Time Difference
Cold 12.27s +307.00ms
Cached 561.00ms +44.00ms ⚠️

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

AtlasKit Editor ✅

Timings

Description Time Difference
Cold 1.32m +985.00ms
Cached 1.95s +58.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

Bundle Size Difference Time Difference
dist/editorView.8daeea01.js 594.83kb +0.00b 45.90s -15.22s 🚀
dist/popup.64bc9a82.js 209.67kb +0.00b 45.89s -15.22s 🚀
dist/EmojiPickerComponent.2bc79859.js 146.67kb +0.00b 37.81s +13.17s ⚠️
dist/Toolbar.e3ba4416.js 107.23kb +0.00b 45.90s -15.22s 🚀
dist/Modal.cd71eaf3.js 45.33kb +0.00b 45.89s -15.22s 🚀
dist/esm.f1a592e5.js 33.15kb +0.00b 37.81s +13.17s ⚠️
dist/DatePicker.f2994e45.js 22.98kb +0.00b 37.81s +13.17s ⚠️
dist/ui.5d3f7adc.js 14.94kb +0.00b 45.89s -15.22s 🚀
dist/smartMediaEditor.48c8cf63.js 13.25kb +0.00b 45.90s -15.22s 🚀
dist/dropzone.e0209bf8.js 12.15kb +0.00b 45.90s -15.22s 🚀
dist/EmojiPickerComponent.0482d6c0.js 3.73kb +0.00b 45.89s -15.22s 🚀
dist/dropzone.55bef257.js 3.29kb +0.00b 45.89s -15.22s 🚀
dist/clipboard.df70240c.js 2.93kb +0.00b 45.90s -15.22s 🚀
dist/ResourcedEmojiComponent.667554b4.js 2.12kb +0.00b 45.89s -15.22s 🚀
dist/feedback.c7e69064.js 1.77kb +0.00b 37.81s +13.17s ⚠️
dist/browser.4e039ed7.js 1.69kb +0.00b 45.90s -15.22s 🚀
dist/workerHasher.3639b1f9.js 1.63kb +0.00b 37.81s +13.17s ⚠️
dist/heading6.a693146e.js 1.51kb +0.00b 37.81s +13.17s ⚠️
dist/heading5.8bfafe21.js 1.38kb +0.00b 37.80s +13.17s ⚠️
dist/expand.a44d10fe.js 1.29kb +0.00b 37.81s +13.17s ⚠️
dist/media-card-analytics-error-boundary.c718a9a7.js 1.12kb +0.00b 45.90s -15.22s 🚀
dist/media-picker-analytics-error-boundary.8b2547e5.js 966.00b +0.00b 45.89s -15.22s 🚀
dist/simpleHasher.fc0d6100.js 643.00b +0.00b 45.89s -15.22s 🚀

Three.js ✅

Timings

Description Time Difference
Cold 8.16s -271.00ms
Cached 432.00ms +22.00ms ⚠️

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

Click here to view a detailed benchmark overview.

@evaera
Copy link

evaera commented Oct 26, 2021

This comment seems to mention that the pending fix in this PR isn't all there is to it:

#6905 (comment)

Haven't confirmed, but maybe there's more that needs to be changed?

@mischnic
Copy link
Member Author

mischnic commented Oct 26, 2021 •
edited
Loading

I actually didn't notice that comment until now 😬

targets.length > 0 is definitely correct. That caching issue is not directly related

-> #7215

@mischnic mischnic merged commit c8a64c9 into v2 Oct 31, 2021
@mischnic mischnic deleted the 6905-target-source-env branch October 31, 2021 08:57
@mischnic mischnic mentioned this pull request Nov 8, 2021
Closed
lettertwo added a commit that referenced this pull request Nov 15, 2021
@lettertwo
Merge branch 'v2' into lettertwo/buffer-backed-graph
4f219c8 
* v2: (68 commits)
  Fix RangeError in `not export` error with other file type (#7295)
  Apply sourcemap in @parcel/transformer-typescript-tsc (#7287)
  Fix side effects glob matching (#7288)
  Fix changelog headings
  v2.0.1
  Changelog for v2.0.1
  Resolve GLSL relative to the importer, not the asset (#7263)
  fix: add @parcel/diagnostic as dependency of @parcel/transformer-typescript-types (#7248)
  Fixed missing "Parcel" export member in Module "@parcel/core" (#7250)
  Add script to sync engines with core version (#7207)
  Bump swc (#7216)
  Make Webpack loader detection regex dramatically faster (#7226)
  swc optimizer (#7212)
  Update esbuild in optimizer (#7233)
  Properly visit member expressions (#7228)
  Update to prettier 2 (#7209)
  Fix serve mode with target override and target source fields (#7187)
  Update package.json to include the repository (#7184)
  fix #6730: add transformer-raw as dependency of config-webextension (#7193)
  Log warning instead of crash if image optimizer fails (#7119)
  ...
lettertwo added a commit that referenced this pull request Nov 15, 2021
@lettertwo
Merge branch 'v2' into lettertwo/buffer-backed-graph
73cf858 
* v2: (68 commits)
  Fix RangeError in `not export` error with other file type (#7295)
  Apply sourcemap in @parcel/transformer-typescript-tsc (#7287)
  Fix side effects glob matching (#7288)
  Fix changelog headings
  v2.0.1
  Changelog for v2.0.1
  Resolve GLSL relative to the importer, not the asset (#7263)
  fix: add @parcel/diagnostic as dependency of @parcel/transformer-typescript-types (#7248)
  Fixed missing "Parcel" export member in Module "@parcel/core" (#7250)
  Add script to sync engines with core version (#7207)
  Bump swc (#7216)
  Make Webpack loader detection regex dramatically faster (#7226)
  swc optimizer (#7212)
  Update esbuild in optimizer (#7233)
  Properly visit member expressions (#7228)
  Update to prettier 2 (#7209)
  Fix serve mode with target override and target source fields (#7187)
  Update package.json to include the repository (#7184)
  fix #6730: add transformer-raw as dependency of config-webextension (#7193)
  Log warning instead of crash if image optimizer fails (#7119)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devongovett devongovett devongovett approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error with multiple Targets: "TypeError: Cannot read property 'env' of undefined"
4 participants
@mischnic @parcel-benchmark @evaera @devongovett