Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --rev option to allow for bundle revisions #756

Closed
wants to merge 1 commit into from

Conversation

gamebox
Copy link

@gamebox gamebox commented Feb 6, 2018

This is related to #753

@codecov-io
Copy link

Codecov Report

Merging #756 into master will decrease coverage by 0.23%.
The diff coverage is 60%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #756      +/-   ##
==========================================
- Coverage   94.35%   94.11%   -0.24%     
==========================================
  Files          64       64              
  Lines        2036     2040       +4     
==========================================
- Hits         1921     1920       -1     
- Misses        115      120       +5
Impacted Files Coverage Δ
src/Bundler.js 91.48% <ø> (ø) ⬆️
src/packagers/Packager.js 81.25% <60%> (-10.42%) ⬇️
src/assets/CSSAsset.js 82.35% <0%> (-7.36%) ⬇️
src/Logger.js 96.96% <0%> (+1.51%) ⬆️
src/WorkerFarm.js 93.22% <0%> (+1.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3fcfa0...5463257. Read the comment docs.

@lbguilherme
Copy link
Contributor

  1. I don't think this behavior need to be behind a flag. Is there a downside of always adding the hash?
  2. The outer bundle probably shouldn't have hash, as it is referred by name (the index.html).
  3. RawPackager needs work too, as it doesn't use setup from Packager.

@devongovett
Copy link
Member

Should be solved by #1025 which generates content-hashed filenames for static assets. Please help test using the master branch - a release will hopefully come next week!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants