Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Node 12 in tests and add Node 16 #7935

Merged
merged 2 commits into from
Apr 26, 2022
Merged

Drop Node 12 in tests and add Node 16 #7935

merged 2 commits into from
Apr 26, 2022

Conversation

mischnic
Copy link
Member

@mischnic mischnic commented Apr 11, 2022

Node 12 is EOL at the end of April.

We should add Node 16 to CI, but also the the number of jobs should stay the same to not make flakeyness even worse. So either

  • keep Node 12 and remove 14
  • remove Node 12 but still transpile our code for Node 12 ("deprecate" it)
  • remove Node 12, and bump engines to Node 14 (this would be a breaking change though).

@parcel-benchmark
Copy link

parcel-benchmark commented Apr 11, 2022

Benchmark Results

Kitchen Sink 🚨

Timings

Description Time Difference
Cold FAILED -0.00ms
Cached FAILED -0.00ms

Cold Bundles

No bundles found, this is probably a failed build...

Cached Bundles

No bundles found, this is probably a failed build...

React HackerNews ✅

Timings

Description Time Difference
Cold 10.62s +155.00ms
Cached 511.00ms -57.00ms 🚀

Cold Bundles

Bundle Size Difference Time Difference
dist/logo.c5bb83f1.png 246.00b +0.00b 5.48s +711.00ms ⚠️

Cached Bundles

No bundle changes detected.

AtlasKit Editor 🚨

Timings

Description Time Difference
Cold FAILED -0.00ms
Cached FAILED -0.00ms

Cold Bundles

No bundles found, this is probably a failed build...

Cached Bundles

No bundles found, this is probably a failed build...

Three.js ✅

Timings

Description Time Difference
Cold 7.43s -344.00ms
Cached 312.00ms +15.00ms

Cold Bundles

Bundle Size Difference Time Difference
dist/Three.js 579.69kb +0.00b 5.29s -279.00ms 🚀

Cached Bundles

No bundle changes detected.

Click here to view a detailed benchmark overview.

@wbinnssmith
Copy link
Contributor

wbinnssmith commented Apr 11, 2022

remove Node 12 but still transpile our code for Node 12 ("deprecate" it)

This makes sense to me, along with a plan to drop Node 12 as a compile target at a specific date in the future. We have apps that still use Node 12 and have Node's EOL as a motivating factor to update, so I wouldn't be surprised if this is the case elsewhere too. As grace period, maybe some time around October when Node cuts major releases anyway?

We can probably drop Node 12 from CI now or once we get a plan to support 16 there (re: the vm issue)

@mischnic mischnic marked this pull request as draft April 14, 2022 19:36
Comment on lines +991 to +992
importModuleDynamically: (specifier, referrer) =>
entry(specifier, referrer),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The vm module used in the integration tests requires a change for Node 16. The only item regarding vm in the changelog

A prime example of how adding a paramater to a callback is a breaking change...

@mischnic mischnic marked this pull request as ready for review April 22, 2022 17:03
@mischnic
Copy link
Member Author

@devongovett You'll have to merge this because it removed some required CI jobs (and probably also change which checks are required in the settings).

@devongovett devongovett merged commit ffcc995 into v2 Apr 26, 2022
@devongovett devongovett deleted the node-16 branch April 26, 2022 17:03
gorakong pushed a commit that referenced this pull request Nov 3, 2022
…2022-04-22

* upstream/v2:
  Add test for storing empty assets with LMDB (#7995)
  GitHub Actions: disable fail-fast for integration_tests (#8007)
  Drop Node 12 in tests and add Node 16 (#7935)
  Update Flow to 0.176.3 (#8006)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants