Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly emit warnings for unnecessary PostCSS plugins in package.json #8024

Merged
merged 3 commits into from
May 1, 2022

Conversation

mischnic
Copy link
Member

When declaring the postcss config in package.json, the json paths for the diagnostic need to be prefixed (by the "postcss" packageKey argument to loadConfig).

Closes #7984

@parcel-benchmark
Copy link

parcel-benchmark commented Apr 29, 2022

Benchmark Results

Kitchen Sink 🚨

Timings

Description Time Difference
Cold FAILED -0.00ms
Cached FAILED -0.00ms

Cold Bundles

No bundles found, this is probably a failed build...

Cached Bundles

No bundles found, this is probably a failed build...

React HackerNews ✅

Timings

Description Time Difference
Cold 8.82s -70.00ms
Cached 437.00ms -0.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

AtlasKit Editor ✅

Timings

Description Time Difference
Cold 1.51m +255.00ms
Cached 2.41s -27.00ms

Cold Bundles

Bundle Size Difference Time Difference
dist/index.9eefec02.js 3.32mb +144.00b ⚠️ 29.57s +89.00ms
dist/esm.6190c9ac.js 61.54kb +0.00b 1.14m +31.07s ⚠️
dist/workerHasher.e50d242f.js 1.72kb +0.00b 1.14m +31.07s ⚠️
dist/16.1969624f.js 1.08kb +0.00b 36.64s +3.21s ⚠️
dist/16.069344b7.js 905.00b +0.00b 36.64s +3.21s ⚠️
dist/simpleHasher.46d6f2e5.js 742.00b +0.00b 1.14m +31.07s ⚠️
dist/index.html 240.00b +0.00b 1.14m +38.65s ⚠️

Cached Bundles

Bundle Size Difference Time Difference
dist/index.2009fd6f.js 3.32mb +144.00b ⚠️ 29.36s -114.00ms
dist/esm.6190c9ac.js 61.54kb +0.00b 1.14m +31.28s ⚠️
dist/workerHasher.e50d242f.js 1.72kb +0.00b 1.14m +31.28s ⚠️
dist/16.1969624f.js 1.08kb +0.00b 36.78s +3.30s ⚠️
dist/index.html 240.00b +0.00b 1.14m +35.92s ⚠️

Three.js ✅

Timings

Description Time Difference
Cold 6.36s +29.00ms
Cached 259.00ms -2.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

Click here to view a detailed benchmark overview.

@mischnic mischnic merged commit 0c9d93f into v2 May 1, 2022
@mischnic mischnic deleted the postcss-warning-package branch May 1, 2022 15:46
gorakong pushed a commit that referenced this pull request Nov 3, 2022
…2022-04-22

* upstream/v2:
  Register swc error handler (#8032)
  Correctly emit warnings for unnecessary PostCSS plugins in package.json (#8024)
  Pass targets for swc/helpers to Rust and only filter them for preset env (#8020)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] Got unexpected undefined error with latest PostCSS transformer
3 participants