Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for non-identifier symbol names #8388

Merged
merged 4 commits into from
Oct 2, 2023
Merged

Conversation

mischnic
Copy link
Member

When I changed the variable format to $assetId$export$unhashedExportName (as opposed to hashing the last part), no tests were failing...

@parcel-benchmark
Copy link

parcel-benchmark commented Aug 10, 2022

Benchmark Results

Kitchen Sink ✅

Timings

Description Time Difference
Cold 1.52s +40.00ms
Cached 273.00ms -8.00ms

Cold Bundles

Bundle Size Difference Time Difference
dist/legacy/index.html 826.00b +0.00b 415.00ms +23.00ms ⚠️
dist/modern/index.html 749.00b +0.00b 413.00ms +21.00ms ⚠️

Cached Bundles

Bundle Size Difference Time Difference
dist/legacy/index.ff03421b.js 1.48kb +0.00b 380.00ms -27.00ms 🚀
dist/legacy/index.e9bb1616.js 1.06kb +0.00b 380.00ms -28.00ms 🚀
dist/modern/index.4a29d309.js 921.00b +0.00b 379.00ms -29.00ms 🚀

React HackerNews ✅

Timings

Description Time Difference
Cold 3.96s -34.00ms
Cached 409.00ms -25.00ms 🚀

Cold Bundles

No bundle changes detected.

Cached Bundles

Bundle Size Difference Time Difference
dist/PermalinkedComment.e9dc4a75.js 3.92kb +0.00b 335.00ms -30.00ms 🚀
dist/UserProfile.8945a243.js 1.38kb +0.00b 335.00ms -30.00ms 🚀
dist/NotFound.8b44a81d.js 269.00b +0.00b 335.00ms -29.00ms 🚀
dist/logo.8dd07848.png 244.00b +0.00b 238.00ms -18.00ms 🚀

AtlasKit Editor ✅

Timings

Description Time Difference
Cold 35.70s +283.00ms
Cached 2.33s +28.00ms

Cold Bundles

Bundle Size Difference Time Difference
dist/media-viewer.38e3999a.js 536.13kb +0.00b 11.56s +3.18s ⚠️
dist/ConfigPanelFieldsLoader.182d39bc.js 303.43kb +0.00b 7.94s -445.00ms 🚀
dist/card.d06de810.js 138.91kb +0.00b 7.94s -442.00ms 🚀
dist/ConfigPanelFieldsLoader.28b428a5.js 82.73kb +0.00b 11.34s +937.00ms ⚠️
dist/ElementBrowser.e8f01080.js 61.94kb +0.00b 7.94s -443.00ms 🚀
dist/esm.bfca2115.js 59.30kb +0.00b 7.94s -444.00ms 🚀
dist/ConfigPanelFieldsLoader.2b7c03be.js 15.74kb +0.00b 7.94s -443.00ms 🚀
dist/ui.8c117104.js 14.48kb +0.00b 7.94s -443.00ms 🚀
dist/ConfigPanelFieldsLoader.5dfde67d.js 13.63kb +0.00b 7.94s -443.00ms 🚀
dist/pdfRenderer.01deafa1.js 12.04kb +0.00b 11.53s +3.15s ⚠️
dist/mobile-upload.3baad8e4.js 7.79kb +0.00b 7.94s -443.00ms 🚀
dist/mobile-upload.7a892a37.js 7.79kb +0.00b 7.94s -442.00ms 🚀
dist/ru.0cf3f40e.js 2.81kb +0.00b 7.94s -444.00ms 🚀
dist/uk.282f23b1.js 2.76kb +0.00b 7.94s -443.00ms 🚀
dist/th.137e1013.js 2.60kb +0.00b 7.94s -443.00ms 🚀
dist/pl.bce591be.js 2.25kb +0.00b 7.36s +1.21s ⚠️
dist/vi.b46097db.js 2.09kb +0.00b 7.94s -443.00ms 🚀
dist/pt_BR.b9e37d37.js 2.06kb +0.00b 7.64s +1.49s ⚠️
dist/tr.c85d90a9.js 2.03kb +0.00b 7.94s -444.00ms 🚀
dist/sv.1c06c95c.js 1.98kb +0.00b 7.94s -443.00ms 🚀
dist/zh_TW.b7c55aa6.js 1.86kb +0.00b 7.94s -443.00ms 🚀
dist/zh.b01fe721.js 1.84kb +0.00b 7.94s -443.00ms 🚀
dist/workerHasher.540c9790.js 1.56kb +0.00b 7.94s -443.00ms 🚀
dist/workerHasher.c840c607.js 1.56kb +0.00b 7.94s -442.00ms 🚀
dist/heading3.73972e33.js 1.35kb +0.00b 6.04s +576.00ms ⚠️
dist/heading4.be08fc9e.js 1.12kb +0.00b 6.04s +575.00ms ⚠️
dist/sk.4be9c93f.js 656.00b +0.00b 7.94s -444.00ms 🚀
dist/pt_PT.e211e609.js 635.00b +0.00b 7.64s +1.49s ⚠️
dist/simpleHasher.c14e20b4.js 589.00b +0.00b 7.94s -443.00ms 🚀
dist/simpleHasher.23db7a52.js 589.00b +0.00b 7.94s -442.00ms 🚀
dist/ro.8d5b380a.js 482.00b +0.00b 7.94s -444.00ms 🚀

Cached Bundles

Bundle Size Difference Time Difference
dist/codeViewerRenderer.51140ec8.js 2.61kb +0.00b 11.70s +3.47s ⚠️
dist/heading4.be08fc9e.js 1.12kb +0.00b 5.36s -650.00ms 🚀
dist/ro.8d5b380a.js 482.00b +0.00b 8.04s +1.94s ⚠️

Three.js ✅

Timings

Description Time Difference
Cold 2.94s +19.00ms
Cached 316.00ms -2.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

Click here to view a detailed benchmark overview.

@mischnic mischnic merged commit f3b5fbe into v2 Oct 2, 2023
15 of 16 checks passed
@mischnic mischnic deleted the test-non-identifier-symbols branch October 2, 2023 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants