Refactor prettifySize #883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Untangles if/else in favor of returns.
Codecov Report
@@ Coverage Diff @@
## master #883 +/- ##
==========================================
- Coverage 88.92% 88.77% -0.15%
==========================================
Files 68 68
Lines 3440 3439 -1
==========================================
- Hits 3059 3053 -6
- Misses 381 386 +5
Continue to review full report at Codecov.
|
brandon93s
approved these changes
Feb 23, 2018
devongovett
pushed a commit
that referenced
this pull request
Oct 15, 2018
Untangles if/else in favor of returns.
devongovett
pushed a commit
that referenced
this pull request
Oct 15, 2018
Untangles if/else in favor of returns.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Untangles if/else in favor of returns.