Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Flow suppression for require.resolve options #9160

Merged
merged 3 commits into from
Jul 31, 2023
Merged

Remove Flow suppression for require.resolve options #9160

merged 3 commits into from
Jul 31, 2023

Conversation

imbrian
Copy link
Contributor

@imbrian imbrian commented Jul 28, 2023

↪️ Pull Request

Cleans up Flow error suppression comment for require.resolve options param in cli.js.

This comment was needed when the use of require.resolve was added, but the type has since been fixed in Flow in 0.153.0. Parcel is using 0.184.0.

💻 Examples

n/a

🚨 Test instructions

yarn flow check does not error with the comment removed.

✔️ PR Todo

  • Added/updated unit tests for this change
  • Filled out test instructions (In case there aren't any unit tests)
  • Included links to related issues/PRs

@mischnic mischnic merged commit 2c3db37 into parcel-bundler:v2 Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mischnic mischnic mischnic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@imbrian @mischnic