Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't autoinstall local files in package manager #9242

Merged
merged 4 commits into from
Oct 1, 2023

Conversation

mischnic
Copy link
Member

Closes #9240

@parcel-benchmark
Copy link

parcel-benchmark commented Sep 13, 2023

Benchmark Results

Kitchen Sink ✅

Timings

Description Time Difference
Cold 1.45s -14.00ms
Cached 236.00ms -11.00ms

Cold Bundles

Bundle Size Difference Time Difference
dist/legacy/parcel.7cdb0fad.webp 102.94kb +0.00b 250.00ms +14.00ms ⚠️
dist/legacy/parcel.7cdb0fad.webp 102.94kb +0.00b 256.00ms +19.00ms ⚠️
dist/modern/parcel.7cdb0fad.webp 102.94kb +0.00b 256.00ms +19.00ms ⚠️
dist/legacy/index.ff03421b.js 1.48kb +0.00b 375.00ms +36.00ms ⚠️
dist/legacy/index.e9bb1616.js 1.06kb +0.00b 375.00ms +35.00ms ⚠️
dist/modern/index.4a29d309.js 921.00b +0.00b 375.00ms +35.00ms ⚠️

Cached Bundles

Bundle Size Difference Time Difference
dist/legacy/parcel.7cdb0fad.webp 102.94kb +0.00b 252.00ms +13.00ms ⚠️
dist/legacy/index.ff03421b.js 1.48kb +0.00b 379.00ms +36.00ms ⚠️
dist/legacy/index.e9bb1616.js 1.06kb +0.00b 379.00ms +37.00ms ⚠️
dist/modern/index.4a29d309.js 921.00b +0.00b 378.00ms +36.00ms ⚠️
dist/modern/index.31cedca9.css 94.00b +0.00b 258.00ms +13.00ms ⚠️

React HackerNews ✅

Timings

Description Time Difference
Cold 3.79s +28.00ms
Cached 388.00ms -9.00ms

Cold Bundles

Bundle Size Difference Time Difference
dist/PermalinkedComment.e9dc4a75.js 3.92kb +0.00b 317.00ms -42.00ms 🚀
dist/UserProfile.8945a243.js 1.38kb +0.00b 317.00ms -42.00ms 🚀
dist/NotFound.8b44a81d.js 269.00b +0.00b 317.00ms -42.00ms 🚀
dist/logo.8dd07848.png 244.00b +0.00b 234.00ms +24.00ms ⚠️

Cached Bundles

Bundle Size Difference Time Difference
dist/PermalinkedComment.e9dc4a75.js 3.92kb +0.00b 361.00ms +48.00ms ⚠️
dist/UserProfile.8945a243.js 1.38kb +0.00b 360.00ms +47.00ms ⚠️
dist/NotFound.8b44a81d.js 269.00b +0.00b 361.00ms +48.00ms ⚠️

AtlasKit Editor ✅

Timings

Description Time Difference
Cold 30.42s -271.00ms
Cached 2.11s +62.00ms

Cold Bundles

Bundle Size Difference Time Difference
dist/card.d06de810.js 138.91kb +0.00b 9.15s +2.21s ⚠️
dist/esm.bfca2115.js 59.30kb +0.00b 9.15s +2.21s ⚠️
dist/component-lazy.51d1dec9.js 58.94kb +0.00b 5.15s +372.00ms ⚠️
dist/DatePicker.042aeb21.js 47.46kb +0.00b 5.15s +373.00ms ⚠️
dist/DatePicker.dd4c3679.js 24.96kb +0.00b 5.15s +373.00ms ⚠️
dist/pdfRenderer.01deafa1.js 12.04kb +0.00b 9.15s +2.21s ⚠️
dist/mobile-upload.7a892a37.js 7.79kb +0.00b 9.15s +2.20s ⚠️
dist/ResourcedEmojiComponent.9a253c26.js 2.47kb +0.00b 5.15s +372.00ms ⚠️
dist/pl.bce591be.js 2.25kb +0.00b 6.11s +1.33s ⚠️
dist/cs.bf42283b.js 2.23kb +0.00b 5.15s +373.00ms ⚠️
dist/de.90d5c4fa.js 2.17kb +0.00b 5.15s +373.00ms ⚠️
dist/fr.ff5d335f.js 2.13kb +0.00b 5.15s +372.00ms ⚠️
dist/es.80bf0476.js 2.12kb +0.00b 5.15s +373.00ms ⚠️
dist/hu.223c2cde.js 2.10kb +0.00b 5.15s +373.00ms ⚠️
dist/fi.98bb8fa8.js 2.09kb +0.00b 5.15s +372.00ms ⚠️
dist/ja.7d4156df.js 2.09kb +0.00b 6.11s +1.33s ⚠️
dist/pt_BR.b9e37d37.js 2.06kb +0.00b 6.11s +1.33s ⚠️
dist/ko.9c6bf469.js 1.98kb +0.00b 6.11s +1.33s ⚠️
dist/it.04edb54a.js 1.97kb +0.00b 5.15s +373.00ms ⚠️
dist/nb.9bd6db78.js 1.96kb +0.00b 6.11s +1.33s ⚠️
dist/date.139a08b0.js 1.95kb +0.00b 4.54s +233.00ms ⚠️
dist/da.d2d8303e.js 1.95kb +0.00b 5.15s +373.00ms ⚠️
dist/nl.c4d12122.js 1.94kb +0.00b 6.11s +1.33s ⚠️
dist/images.774ef3be.js 1.90kb +0.00b 4.54s +232.00ms ⚠️
dist/feedback.4b745631.js 1.76kb +0.00b 5.15s +372.00ms ⚠️
dist/status.20808f9b.js 1.67kb +0.00b 5.10s +786.00ms ⚠️
dist/code.3ce450f8.js 1.56kb +0.00b 4.54s +233.00ms ⚠️
dist/workerHasher.c840c607.js 1.56kb +0.00b 9.15s +2.20s ⚠️
dist/list-number.fdc97a50.js 1.47kb +0.00b 4.54s +232.00ms ⚠️
dist/heading6.e6e03f52.js 1.36kb +0.00b 5.15s +373.00ms ⚠️
dist/heading3.73972e33.js 1.35kb +0.00b 5.10s +787.00ms ⚠️
dist/link.71e06c5e.js 1.28kb +0.00b 4.54s +232.00ms ⚠️
dist/emoji.8f9f45dc.js 1.25kb +0.00b 4.54s +232.00ms ⚠️
dist/heading5.d2f94d9d.js 1.23kb +0.00b 5.15s +373.00ms ⚠️
dist/expand.c983e90a.js 1.18kb +0.00b 5.15s +372.00ms ⚠️
dist/heading2.c27d912d.js 1.17kb +0.00b 5.10s +787.00ms ⚠️
dist/heading4.be08fc9e.js 1.12kb +0.00b 5.10s +787.00ms ⚠️
dist/mention.f4723418.js 1.09kb +0.00b 4.54s +232.00ms ⚠️
dist/layout.b5e3a7ef.js 1.05kb +0.00b 4.54s +231.00ms ⚠️
dist/divider.7bb33712.js 1.04kb +0.00b 4.54s +232.00ms ⚠️
dist/action.c407ac14.js 1.02kb +0.00b 4.54s +233.00ms ⚠️
dist/heading1.d7caae19.js 1.02kb +0.00b 5.10s +786.00ms ⚠️
dist/list.bd698aa0.js 1011.00b +0.00b 4.54s +232.00ms ⚠️
dist/quote.d6bda47a.js 1011.00b +0.00b 5.10s +786.00ms ⚠️
dist/decision.a17a0d00.js 992.00b +0.00b 4.54s +233.00ms ⚠️
dist/panel-warning.772e8569.js 968.00b +0.00b 4.54s +233.00ms ⚠️
dist/16.549c63e3.js 955.00b +0.00b 4.54s +233.00ms ⚠️
dist/table.e0e68580.js 946.00b +0.00b 5.10s +786.00ms ⚠️
dist/panel.45c00b08.js 887.00b +0.00b 4.54s +232.00ms ⚠️
dist/panel-error.bfda44fb.js 864.00b +0.00b 4.54s +233.00ms ⚠️
dist/16.bf9fb66d.js 821.00b +0.00b 4.54s +233.00ms ⚠️
dist/panel-success.4afcba7a.js 805.00b +0.00b 4.54s +233.00ms ⚠️
dist/panel-note.58ef2b52.js 795.00b +0.00b 4.54s +233.00ms ⚠️
dist/16.c715b7e1.js 746.00b +0.00b 4.54s +233.00ms ⚠️
dist/pt_PT.e211e609.js 635.00b +0.00b 6.11s +1.33s ⚠️
dist/et.88ef7cb4.js 633.00b +0.00b 5.15s +373.00ms ⚠️
dist/simpleHasher.23db7a52.js 589.00b +0.00b 9.15s +2.20s ⚠️
dist/is.5f045a22.js 495.00b +0.00b 5.15s +373.00ms ⚠️
dist/en_GB.4c40e6c6.js 472.00b +0.00b 5.15s +373.00ms ⚠️
dist/en.e1d21f6d.js 469.00b +0.00b 5.15s +373.00ms ⚠️
dist/index.html 248.00b +0.00b 9.78s +2.96s ⚠️

Cached Bundles

Bundle Size Difference Time Difference
dist/pdfRenderer.01deafa1.js 12.04kb +0.00b 6.73s -2.39s 🚀
dist/pl.bce591be.js 2.25kb +0.00b 5.02s -1.77s 🚀
dist/ro.8d5b380a.js 482.00b +0.00b 6.74s +1.78s ⚠️

Three.js ✅

Timings

Description Time Difference
Cold 2.76s -37.00ms
Cached 305.00ms +3.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

Click here to view a detailed benchmark overview.

@devongovett devongovett merged commit 4499a71 into v2 Oct 1, 2023
15 of 16 checks passed
@devongovett devongovett deleted the autoinstall-local-file branch October 1, 2023 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parcel tries to install package on missing local plugin
3 participants