Support "register" tools in module loader #9285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hmm.. I wonder what happened there.. maybe it's the Atlassian package registry. I'll have a look. EDIT Fixed it.. for some reason I accidentally used |
Benchmark ResultsKitchen Sink ✅
Timings
Cold Bundles
Cached Bundles
React HackerNews ✅
Timings
Cold Bundles
Cached BundlesNo bundle changes detected. AtlasKit Editor ✅
Timings
Cold Bundles
Cached Bundles
Three.js ✅
Timings
Cold BundlesNo bundle changes detected. Cached BundlesNo bundle changes detected. |
mattcompiles
approved these changes
Oct 3, 2023
marcins
deleted the
mszczepanski/support-register-tools-in-module-loader
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
↪️ Pull Request
This change modifies the
NodePackageManagerto support loading modules when using tools likeesbuild-registerorts-node.Essentially these tools work by modifying
Module._extensionsto add handlers for additional extensions (like.ts). We now pass this extension list to the resolver instance we create inNodePackageManager, and whenever we create a new Module we check whether the list of extensions has been amended.This means that when using tools like
ts-nodeoresbuild-register, Parcel plugins can be written in TypeScript.🚨 Test instructions
Added a new integration test which uses a reporter written in TS, and
esbuild-register.I considered adding an integration test using
ts-node, but I did a manual check and verified it also works, and it's pretty much the same asesbuild-registerin terms of mechanics so didn't think it was worth the extra dependency.✔️ PR Todo