-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce redundancy in the RequestGraph's file nodes #9360
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…duce-requestGraph-fileNodes
gorakong
changed the title
Reduce redundancy in file nodes in the RequestGraph
Reduce redundancy in the RequestGraph's file nodes
Nov 2, 2023
…ce-requestGraph-fileNodes
…el-bundler/parcel into gkong/reduce-requestGraph-fileNodes
gorakong
commented
Nov 2, 2023
gorakong
requested review from
lettertwo,
JakeLane,
mattcompiles,
thebriando and
AGawrys
November 2, 2023 22:04
JakeLane
approved these changes
Nov 2, 2023
lettertwo
suggested changes
Nov 2, 2023
lettertwo
approved these changes
Nov 2, 2023
thebriando
approved these changes
Nov 2, 2023
devongovett
approved these changes
Nov 3, 2023
AGawrys
approved these changes
Nov 3, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
↪️ Pull Request
This PR reduces redundancy in the RequestGraph's file nodes (which account for close to 50% of the RequestGraph's nodes) by getting rid of the
value
object in each of them, since these can be derived from their IDs. On a large app, this nets us a 6.3% reduction in the size of the serialized RequestGraph.💻 Examples
Before:
After: