Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print phase times on development builds #9417

Merged
merged 10 commits into from
Dec 7, 2023
Merged

Conversation

imbrian
Copy link
Contributor

@imbrian imbrian commented Dec 4, 2023

↪️ Pull Request

Phase timings can currently be shown via PARCEL_SHOW_PHASE_TIMES on production mode builds.

This PR extends this to development builds, resetting phase start times on the first buildProgress after a buildSuccess, so phase times can be debugged on incremental development builds.

✔️ PR Todo

  • Added/updated unit tests for this change
  • Included links to related issues/PRs

@imbrian imbrian requested a review from irismoini December 4, 2023 18:25
Copy link
Contributor

@irismoini irismoini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🥳

@imbrian imbrian merged commit ecfeb40 into v2 Dec 7, 2023
15 of 16 checks passed
@imbrian imbrian deleted the imbrian/incremental-bundle-timings branch December 7, 2023 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants