Fix tsconfig extends from node_modules #9419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mischnic
approved these changes
Dec 5, 2023
devongovett
approved these changes
Dec 5, 2023
baltpeter
added a commit
to tweaselORG/ReportHAR
that referenced
this pull request
Jun 4, 2024
zner0L
added a commit
to tweaselORG/ReportHAR
that referenced
this pull request
Jun 23, 2024
* Import har2pdf code * har2pdf: Shift all headings down by one * har2pdf: Make heading referencable * First somewhat working prototype * Description * Only print requests referenced in the report * Reference tracker-wiki in report * Escaping * Outsource style to external file * Controller notices * Complaints * delete unused translations file * Fixes #5: Render App Privacy Report/TrackerControl export * Refactor GenerateOptions * Mention app version in second analysis in complaint * Complaint: Only include requests from user's network activity report * Rename to ReportHAR * Factor out traffic preparation * Factor out Nunjucks code * Factor out Typst compilation * har2pdf: fix typo in encoding detection * extract meta from tweasel HARs * Allow passing harMd5 * Write docstrings * write readme * Fixes #4: Include software versions in report * Add link to HAR tutorial * Export prepareTraffic() We need to do the same thing in platform. * Vendor TweaselHar type While I'm not the biggest fan of duplicating the code, we were also (needlessly) inheriting the Node 18 restriction from CA. Also, CA is pretty huge and I never liked depending on that just for this one type. Since the type is expected to be pretty stable, I don't think vendoring it is too much of an issue. * Upgrade Parcel Due to: parcel-bundler/parcel#9419 * Switch to our custom nunjucks fork * Inline TrackHAR translations in bundle I was getting the following error when trying to use ReportHAR as a library: Module "trackhar/i18n/en.json" needs an import assertion of type "json" But adding the assertion didn't help—Parcel strips those. * Export translations * Support TrackerControl individual app exports * Switch to released TrackHAR * Template for informal complaints * Actually convince Parcel to inline the translations and templates Quite finicky… * Remove yalc and update TrackHAR * Add method section to report --------- Co-authored-by: Lorenz Sieben <me@lorenz-sieben.com>
baltpeter
added a commit
to tweaselORG/ReportHAR
that referenced
this pull request
Jun 25, 2024
* Import har2pdf code * har2pdf: Shift all headings down by one * har2pdf: Make heading referencable * First somewhat working prototype * Description * Only print requests referenced in the report * Reference tracker-wiki in report * Escaping * Outsource style to external file * Controller notices * Complaints * delete unused translations file * Fixes #5: Render App Privacy Report/TrackerControl export * Refactor GenerateOptions * Mention app version in second analysis in complaint * Complaint: Only include requests from user's network activity report * Rename to ReportHAR * Factor out traffic preparation * Factor out Nunjucks code * Factor out Typst compilation * har2pdf: fix typo in encoding detection * extract meta from tweasel HARs * Allow passing harMd5 * Write docstrings * write readme * Fixes #4: Include software versions in report * Add link to HAR tutorial * Export prepareTraffic() We need to do the same thing in platform. * Vendor TweaselHar type While I'm not the biggest fan of duplicating the code, we were also (needlessly) inheriting the Node 18 restriction from CA. Also, CA is pretty huge and I never liked depending on that just for this one type. Since the type is expected to be pretty stable, I don't think vendoring it is too much of an issue. * Upgrade Parcel Due to: parcel-bundler/parcel#9419 * Switch to our custom nunjucks fork * Inline TrackHAR translations in bundle I was getting the following error when trying to use ReportHAR as a library: Module "trackhar/i18n/en.json" needs an import assertion of type "json" But adding the assertion didn't help—Parcel strips those. * Export translations * Support TrackerControl individual app exports * Switch to released TrackHAR * Template for informal complaints * Actually convince Parcel to inline the translations and templates Quite finicky… * Remove yalc and update TrackHAR * Add method section to report --------- Co-authored-by: Lorenz Sieben <me@lorenz-sieben.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
↪️ Pull Request
Currently unable to resolve TSConfig
extendsfromnode_modulesin non-browser targets (projects whereincludeNodeModulesdefaults or is set tofalse).This PR changes the resolver used for
tsconfig.extendsto includenode_moduleswhen a package specifier is provided.resolves #9057
🚨 Test instructions
Tested against internal project and example from #9057
✔️ PR Todo