Write tmp files to the OS tmp directory #9580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattcompiles
requested review from
marcins,
MonicaOlejniczak,
JakeLane,
alshdavid and
Nikola-3
JakeLane
approved these changes
Mar 13, 2024
marcins
approved these changes
Mar 13, 2024
| let useOsTmpDir; | ||
| function shouldUseOsTmpDir(filePath) { | ||
| if (useOsTmpDir != null) { | ||
| return useOsTmpDir; |
There was a problem hiding this comment.
I guess there's a tiny risk the /tmp directory becomes un-usable between the first check and the first write, but that seems pretty unlikely?
There was a problem hiding this comment.
I can't even imagine how that would happen. I'm comfortable with a single check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
↪️ Pull Request
This PR attempts to utilize the OS tmp directory for temporary files when streaming content to files. This greatly reduces the amount of events the watcher needs to process during the build. We only use the tmp directory when the following are true:
🚨 Test instructions
We've tested this approach extensively internally.
✔️ PR Todo