Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for globs in package.json#source #9590

Merged
merged 2 commits into from
Mar 20, 2024
Merged

Add support for globs in package.json#source #9590

merged 2 commits into from
Mar 20, 2024

Conversation

devongovett
Copy link
Member

Closes #3821

This implements support for globs in the package.json "source" field, both top-level and inside targets. Multiple globs are also supported when listed in an array.

@mischnic
Copy link
Member

Should this introduce a glob invalidation? Similar to

// If the entry specifier is a glob, add a glob node so
// we invalidate when a new file matches.
if (isGlob(filePath)) {
api.invalidateOnFileCreate({glob: input});
}

@devongovett
Copy link
Member Author

gonna merge this to unblock some stuff, lmk if you see anything else I should change!

@devongovett devongovett merged commit 9f08a86 into v2 Mar 20, 2024
15 of 17 checks passed
@devongovett devongovett deleted the glob-source branch March 20, 2024 15:54
@buvinghausen
Copy link

Thanks @devongovett let me know once you get this out to npm so I can remove my janky hacks from our stack!

@devongovett
Copy link
Member Author

feel free to try the latest canary tag now. otherwise it'll be out in the next regular release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC][V2] Support glob at package.json#source
3 participants