Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #987: srcset not working for source element #992

Merged
merged 1 commit into from
Mar 14, 2018
Merged

fix #987: srcset not working for source element #992

merged 1 commit into from
Mar 14, 2018

Conversation

gnijuohz
Copy link
Contributor

@gnijuohz gnijuohz commented Mar 13, 2018

This should fix #987.

There is a test for img element's srcset already, I'm not sure whether adding a very similar test is the right way to do it.

@codecov-io
Copy link

Codecov Report

Merging #992 into master will decrease coverage by 1.12%.
The diff coverage is 87.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #992      +/-   ##
==========================================
- Coverage   89.46%   88.34%   -1.13%     
==========================================
  Files          68       68              
  Lines        3341     3251      -90     
==========================================
- Hits         2989     2872     -117     
- Misses        352      379      +27
Impacted Files Coverage Δ
src/assets/HTMLAsset.js 85.1% <87.5%> (+1.23%) ⬆️
src/visitors/fs.js 57.63% <0%> (-22.23%) ⬇️
src/visitors/dependencies.js 76.62% <0%> (-9.1%) ⬇️
src/assets/CSSAsset.js 81.73% <0%> (-4.35%) ⬇️
src/visitors/globals.js 92.3% <0%> (-3.85%) ⬇️
src/transforms/babel.js 87.37% <0%> (-2.43%) ⬇️
src/WorkerFarm.js 91.93% <0%> (-1.62%) ⬇️
src/Logger.js 96.55% <0%> (-1.15%) ⬇️
src/utils/getTargetEngines.js 95.5% <0%> (-1.13%) ⬇️
src/assets/JSAsset.js 90.83% <0%> (-0.77%) ⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0dc062f...4c735dc. Read the comment docs.

Copy link
Contributor

@davidnagli davidnagli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@devongovett devongovett merged commit c469751 into parcel-bundler:master Mar 14, 2018
@VladimirVaivada
Copy link

🐛 I am sorry but issue #987 had not been fixed yet, your test.html does not work with parcel-bundler@1.6.2. At least on my machine... Sorry my English )))

@davidnagli
Copy link
Contributor

@VladimirVaivada This PR was only merged a few days ago, we didn't release these changes yet.

@VladimirVaivada
Copy link

👍 Thank you very much! My bad 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 srcset not working for source-element
5 participants