Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update language on approach to transpiling node_modules #415

Merged
merged 2 commits into from
Mar 28, 2019
Merged

Update language on approach to transpiling node_modules #415

merged 2 commits into from
Mar 28, 2019

Conversation

outofambit
Copy link

In light of parcel-bundler/parcel#1655, I've updated this language to be more accurate to the current state of parcel.

@vercel
Copy link

vercel bot commented Mar 25, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

@DeMoorJasper
Copy link
Member

DeMoorJasper commented Mar 28, 2019

This isn't 100% accurate but it is more accurate than the current state I guess. node_modules with a browserlist or engines that is more modern than the projects target will also be transpiled.

Unfortunately this isn't 100% reliable but is more an issue with how package.json is not standardised.

@mrcoles
Copy link

mrcoles commented May 15, 2019

Are you saying the way it handles dependencies is to do default @babel/preset-env on node_modules/ files unless the package.json in that dependency has a "browserslist" or "engines.browsers" key specified in their package.json? I just spent an hour or two debugging why "browserslist": "Chrome >= 41" seemed to not be working the Swiper package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants