-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add allocation logging and visualization #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and organization
Different allocators have different or even no notion of a try. So instead remove tries completely and introduce an allocator agnostic metric to measure how long an allocation takes.
fia0
approved these changes
Jan 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested it on my system and everything worked fine. Thanks for your work on this feature^^
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces an allocation logging feature to
betree
and a visualization script to analyze the generated logs.Key changes:
Allocation Logging:
allocation_log
feature that enables logging of allocation and deallocation events.allocation_log_file_path
.Visualization Script:
scripts/visualize_allocation_log
) to visualize the allocation and deallocation patterns using matplotlib.requirements.txt
to manage dependencies.Code Changes:
Cargo.toml
to include the newallocation_log
feature.SegmentAllocator
to optionally return allocation tries alongside the segment offset.dmu.rs
to write the allocation and deallocation events, as well as writing the global header.database/mod.rs
to include theallocation_log_file_path
config and call the write global header before the tree is build.tree/imp/mod.rs
to use the correct return type of the apply function.Purpose:
This provides insights into how
betree
utilizes its storage space, allowing for better understanding and optimization of the system's performance and future memory allocation strategies. It allows for better debugging of memory-related issues.How to use:
allocation_log
feature when compilingbetree
.scripts/visualize_allocation_log
to visualize the logs. The log file path can be passed as a CLI parameter or specified via the configuration.