Add LocalBuilder checks to CodeInstructionExtensions.LocalIndex
#682
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nytra
changed the title
CodeInstructionExtensions.LocalIndexCodeInstructionExtensions.LocalIndex
This was referenced Aug 18, 2025
This was referenced Aug 25, 2025
This was referenced Nov 13, 2025
This was referenced Nov 24, 2025
This was referenced Dec 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: When calling
CodeInstructionExtensions.LocalIndex, sometimes the operand is a LocalBuilder, currently the code does not handle this.I came across this when I was trying to get the local index from a Stloc_S but the operand was not an int but actually a LocalBuilder. In that case you need to convert operand to LocalBuilder and take the LocalIndex from it. It makes sense for this extension to do this otherwise you need to do it yourself outside.