-
-
Notifications
You must be signed in to change notification settings - Fork 564
Remove redundant Harmony zip artifacts from Platform Tests workflow #711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove redundant Harmony zip artifacts from Platform Tests workflow #711
Conversation
…orkflow Co-authored-by: pardeike <853584+pardeike@users.noreply.github.com>
…ny artifacts during PRs Co-authored-by: pardeike <853584+pardeike@users.noreply.github.com>
|
@copilot I am still not convinced why we need the extra 'Harmony-Release-ubuntu' artefact at all. Every build produces (both for Debug and for Release): three nuget packages and the zip files that I usually attach to the GitHub release page for downloading. Isn't that enough? |
You're absolutely right! The I'll remove the entire "Upload Harmony zip" step from the workflow to eliminate this duplication completely. |
Co-authored-by: pardeike <853584+pardeike@users.noreply.github.com>
pardeike
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot the dotnet-install.sh script - is that something you used internally while working or why is this part of the PR?
…of original repository Co-authored-by: pardeike <853584+pardeike@users.noreply.github.com>
You're absolutely right - the dotnet-install.sh script was accidentally added in my initial commit and was not part of the original repository. It was unrelated to the workflow artifact changes. I've removed it in commit a0f5480. |
Problem
The Platform Tests workflow was creating redundant artifacts for Release builds on Ubuntu. The
Harmony-Release-ubuntuartifact (15 MB) containing packaged zip files was unnecessary because:build-output-ubuntu-Releaseartifact (29.5 MB) is actually needed for test executionSolution
Completely removed the "Upload Harmony zip" step from
.github/workflows/test-build.ymlto eliminate the redundant artifact creation entirely.Impact
build-output-*artifacts needed for testing (eliminates ~15MB redundant artifact)build-output-*artifactsThis change eliminates unnecessary artifact creation while preserving all functionality needed for testing and releases.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.