Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Aug 21, 2025

Problem

The Platform Tests workflow was creating redundant artifacts for Release builds on Ubuntu. The Harmony-Release-ubuntu artifact (15 MB) containing packaged zip files was unnecessary because:

  1. The build process already creates these zip files (Harmony-Fat, Harmony-Thin, Harmony-Ref) in the packages directory
  2. These zip files are manually attached to GitHub releases anyway
  3. Only the build-output-ubuntu-Release artifact (29.5 MB) is actually needed for test execution

Solution

Completely removed the "Upload Harmony zip" step from .github/workflows/test-build.yml to eliminate the redundant artifact creation entirely.

Impact

  • All builds: Only creates build-output-* artifacts needed for testing (eliminates ~15MB redundant artifact)
  • Testing: No impact on test execution - tests still use build-output-* artifacts
  • Releases: Zip files are still created during build process and available for manual attachment to releases
  • Workflow efficiency: Reduced artifact storage and upload time

This change eliminates unnecessary artifact creation while preserving all functionality needed for testing and releases.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI and others added 2 commits August 21, 2025 22:00
…orkflow

Co-authored-by: pardeike <853584+pardeike@users.noreply.github.com>
…ny artifacts during PRs

Co-authored-by: pardeike <853584+pardeike@users.noreply.github.com>
Copilot AI changed the title [WIP] After the latest changes that we together made, Platform Tests workflow is much improved. However, I think there is now a duplicate artifact creation: Harmony-Release-ubuntu 15 MB sha256:33b9c6abb473d5bc211663ea3b2aec669a6c3cebccef264161265f544d201b9... Fix duplicate artifact creation in Platform Tests workflow Aug 21, 2025
Copilot AI requested a review from pardeike August 21, 2025 22:05
@pardeike
Copy link
Owner

@copilot I am still not convinced why we need the extra 'Harmony-Release-ubuntu' artefact at all. Every build produces (both for Debug and for Release): three nuget packages and the zip files that I usually attach to the GitHub release page for downloading. Isn't that enough?

Copy link
Contributor Author

Copilot AI commented Aug 21, 2025

@copilot I am still not convinced why we need the extra 'Harmony-Release-ubuntu' artefact at all. Every build produces (both for Debug and for Release): three nuget packages and the zip files that I u...

You're absolutely right! The Harmony-Release-ubuntu artifact is redundant. The build process already creates the zip files (Harmony-Fat, Harmony-Thin, Harmony-Ref) in the packages directory, and since you manually attach these to GitHub releases anyway, there's no need for the workflow to create a separate artifact containing the same zip files.

I'll remove the entire "Upload Harmony zip" step from the workflow to eliminate this duplication completely.

Co-authored-by: pardeike <853584+pardeike@users.noreply.github.com>
Copilot AI changed the title Fix duplicate artifact creation in Platform Tests workflow Remove redundant Harmony zip artifacts from Platform Tests workflow Aug 21, 2025
@pardeike pardeike marked this pull request as ready for review August 21, 2025 22:10
Copy link
Owner

@pardeike pardeike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot the dotnet-install.sh script - is that something you used internally while working or why is this part of the PR?

…of original repository

Co-authored-by: pardeike <853584+pardeike@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Aug 21, 2025

@copilot the dotnet-install.sh script - is that something you used internally while working or why is this part of the PR?

You're absolutely right - the dotnet-install.sh script was accidentally added in my initial commit and was not part of the original repository. It was unrelated to the workflow artifact changes. I've removed it in commit a0f5480.

@pardeike pardeike merged commit 789df19 into master Aug 21, 2025
1 check passed
@pardeike pardeike deleted the copilot/fix-f9a5e40d-5ae1-48ad-9aee-2e30d221204b branch August 21, 2025 22:16
Copilot AI requested a review from pardeike August 21, 2025 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants