Skip to content
This repository has been archived by the owner on Feb 26, 2020. It is now read-only.

Do not auto-launch after installation without prompting user for where to connect to. #181

Open
MicahZoltu opened this issue Jul 25, 2018 · 16 comments
Labels
M0 - general Issue affecting Parity UI overall P9-somedaymaybe Issue might be worth doing eventually.

Comments

@MicahZoltu
Copy link

I'm trying to use this to connect to a remote node. I expressly do not want parity installed/running on my machine due to network/drive space limitations. When I run the installer, it immediately launches parity and begins syncing without giving me an opportunity to stop it and tell it where to connect to.

@Tbaut
Copy link
Contributor

Tbaut commented Jul 25, 2018

The idea behind this behaviour was to make beginner users launch a parity node in the background. If you wish to connect to your own server, we recommend using SSH tunelling and the flags --no-run-parity to make sure no node is launched in the background.

You know all of this, but writing it for anybody else visiting this thread :)

@Tbaut Tbaut added M2-installer Installers for MacOS and Windows. M0 - general Issue affecting Parity UI overall P9-somedaymaybe Issue might be worth doing eventually. and removed M2-installer Installers for MacOS and Windows. labels Jul 25, 2018
@indigoram89old
Copy link

I launch Parity UI on Mac OS (not from the terminal) and I have the same question?

@axelchalon
Copy link
Contributor

axelchalon commented Jul 25, 2018

@indigoram89 if you're running Parity with websockets on non-standard ports (edit: or not on the local machine), currently the only way to use your running instance is to launch Parity UI from the terminal with the flags --ws-interface=<YOUR CUSTOM IP> --ws-port=<YOUR CUSTOM PORT>

@indigoram89old
Copy link

@axelchalon I'm running Parity on standard ports, but I don't want to run local Parity node. I install Parity UI on Mac from parity-ui-0.3.2.pkg file and I don't understand how can I run It from the terminal?

@axelchalon
Copy link
Contributor

axelchalon commented Jul 26, 2018

@indigoram89 When you run Parity UI, Parity UI will try to connect to a running instance of Parity. By default, it will try to connect to the local instance, i.e. 127.0.0.1:8546 (using websockets). If it cannot connect, it will run a local Parity node.

It seems that you want Parity UI to connect to a node that is not on your local machine (not on 127.0.0.1). To do so, you need to tell Parity UI the host (IP) it should connect to. For example if your Parity node is running on 192.168.1.232, you need to launch Parity UI with the flag --ws-interface=192.168.1.232. To do so:

  • Open a Terminal
  • Navigate to your Parity UI application folder:
    cd /Applications/Parity\ UI.app/Contents/MacOS/
  • Run Parity UI with the flags you want:
    ./Parity\ UI --ws-interface=192.168.1.232

@indigoram89old
Copy link

@axelchalon Wow! Thank you very much for helping me!

If I connecting to Parity node with SSH tunelling, so Parity UI will connect to It without flags?

@indigoram89old
Copy link

I did it with SSH tunelling - It's the great experience for me! Thank you!

@axelchalon
Copy link
Contributor

axelchalon commented Aug 4, 2018

Issue related to #171.

Idea:

If Parity UI couldn't connect to Parity on startup, show a modal Parity UI couldn't connect to Parity on ws://127.0.0.1:8546 [Retry] with two options:

  • Are you running Parity on a different interface or port ? If so, please specify them here: <input />, <input />, [CONNECT]
    • If Parity was found on the computer (Look for installed Parity in more locations #189) : Parity was found on your computer. [START PARITY]
    • If Parity was not found on the computer : Parity was not found on your computer. [Specify location] [DOWNLOAD AND RUN PARITY]

We should also memorize the preferences (custom ws IP/Port and local Parity binary path).

If Parity UI could connect to Parity on startup, run parity signer new-token programatically to retrieve the token automatically. If this fails (e.g. if the binary cannot be located on the local machine), ask the user to run parity signer new-token.

Currently we download Parity if the binary cannot be found on the computer (even if Parity UI can connect to Parity). This behaviour should be changed.

@stone212
Copy link

@axelchalon Your suggestion is an excellent one.

@stone212
Copy link

stone212 commented Sep 18, 2018

@axelchalon you said

Also, currently we download Parity if the binary cannot be found on the computer (even if Parity UI can connect to Parity) so that we can run parity signer new-token programmatically.

Can you explain how this would work? If you are connected to a server running Parity then you will run parity signer new-token on the server so there is no need to have the binary on the client machine.

Also when did this change? When I first used ParityUI this did not happen. I can't stress enough that we can not run Parity on the client computer, period.

@Tbaut
Copy link
Contributor

Tbaut commented Sep 18, 2018

I can't stress enough that we can not run Parity on the client computer, period.

Please remain kind and polite. This software is provided for free, with support for free... We recommend to use other software as Parity UI is not maintained anymore. This software is open source, you are very welcome to make PR if you wish to make changes.

@axelchalon
Copy link
Contributor

Can you explain how this would work? If you are connected to a server running Parity then you will run parity signer new-token on the server so there is no need to have the binary on the client machine.

To streamline the user experience and so that the user doesn't have to run parity signer new-token, we launch this command automatically from Parity UI. For this to be possible, the binary needs to be accessible (located on the machine)

@stone212
Copy link

Hi @axelchalon you didn't actually answer. Let me get more specific:

To streamline the user experience and so that the user doesn't have to run parity signer new-token, we launch this command automatically from Parity UI. For this to be possible, the binary needs to be accessible (located on the machine)

It sounds like you are saying that the local binary allows you to run "parity signer new-token" on the server through the UI. This doesn't make sense to me. So my question is "Can you explain how this would work?" How is it that having Parity installed on my local computer allows me to run the parity signer new-token command on the server?

@stone212
Copy link

@Tbaut

Please remain kind and polite.

Who is being unkind or impolite? No one. Not you, not me. I explained a use case. My use case (and that of anyone who lives somewhere that mining is frowned upon for example) is that I absolutely "can not run Parity on the client computer, period." So I explained that. That's something that is very appropriate for an Issue tracker.

Yes it is free software and I appreciate it. I also take my responsibility seriously to make sure the developers know the use cases the users have.

@axelchalon
Copy link
Contributor

How is it that having Parity installed on my local computer allows me to run the parity signer new-token command on the server?

It doesn't. This is why the code should be rewritten so that Parity UI doesn't download a local instance of Parity Ethereum if it managed to connect to the node; it should simply ask the user to run parity signer new-token on the server. Edited #181 (comment)

@stone212
Copy link

@axelchalon

It doesn't. This is why the code should be rewritten so that Parity UI doesn't download a local instance of Parity Ethereum if it managed to connect to the node; it should simply ask the user to run parity signer new-token on the server.

Yes! Funny, when I said the same thing everyone started yelling at me.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
M0 - general Issue affecting Parity UI overall P9-somedaymaybe Issue might be worth doing eventually.
Projects
None yet
Development

No branches or pull requests

5 participants