This repository has been archived by the owner on Feb 26, 2020. It is now read-only.
Add dapp-wallet to built-in dapps; load it from fs #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add dapp-wallet to built-in dapps * Modify inject.js to cover local dapp name "v1" (not a hash)
amaury1093
reviewed
May 31, 2018
package.json
Outdated
| @@ -157,6 +157,7 @@ | |||
| }, | |||
| "dependencies": { | |||
| "@parity/api": "2.1.20", | |||
| "@parity/dapp-wallet": "github:js-dist-paritytech/dapp-wallet#037638fec1d3146bc3d3980597cee62b37617373", | |||
There was a problem hiding this comment.
Probably this should go in devDependencies for consistency.
|
Ah, another bug I found: token images are not working anymore. The reason I suppose: the token images are loaded in the code as @axelchalon Could you do a small PR on dapp-wallet to force it to load token images with |
axelchalon
added
the
A3-inprogress
|
Waiting on parity-js/dapp-wallet#13 to be merged; then I'll update the dependency and the PR will be ready! |
axelchalon
removed
the
A3-inprogress
amaury1093
approved these changes
Jun 11, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The wallet retains the same id (v1) as when the dapp was served by Parity, so it shouldn't ask for any new permissions.
I updated inject.js to cover the case of a fs (builtin) dapp with an id that is not a hash.
Also made it so that dapps cannot overwrite already loaded builtin dapps (to ignore the v1
app.type === 'local'served by Parity until it's removed from the node).I'm sometimes getting "Uncaught Error: Provider needs to be supplied to Api instance" (in the wallet at least) or
window.requireerrors; not sure why, don't think it's related to this PR.