This repository has been archived by the owner on Feb 26, 2020. It is now read-only.
Use persistent storage #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enable gitsync
* Remove shell_requestNewToken RPC method. The token must be retrieved internally (by importing DappsRequestsStore in Parity UI), this way we can be sure that the appId is coming from a trusted source. The token, along with the appId, are now passed as query string parameters to the dapp (and to subsequent pages during in-dapp navigation) * Use new version of @parity/api stripped of shell_requestNewToken methods that are now unused * Use synchronous blocking methods in preload.js to maximize chances of web3/parity/ethereum objects being available directly to the dapp, before its own js executes.
|
amaury1093
reviewed
Aug 2, 2018
| // Load inject.js as a string to inject it into the webview with executeJavaScript | ||
| const injectFile = fs.readFileSync(path.join(remote.getGlobal('dirName'), '..', '.build', 'inject.js'), 'utf8'); | ||
|
|
||
| webFrame.executeJavaScript(injectFile); |
amaury1093
approved these changes
Aug 2, 2018
amaury1093
added
A8-looksgood
amaury1093
pushed a commit
that referenced
this pull request
Aug 2, 2018
* Use persistent storage for webviews * Update .gitlab-ci.yml enable gitsync * Retrieve dapp token internally * Remove shell_requestNewToken RPC method. The token must be retrieved internally (by importing DappsRequestsStore in Parity UI), this way we can be sure that the appId is coming from a trusted source. The token, along with the appId, are now passed as query string parameters to the dapp (and to subsequent pages during in-dapp navigation) * Use new version of @parity/api stripped of shell_requestNewToken methods that are now unused * Use synchronous blocking methods in preload.js to maximize chances of web3/parity/ethereum objects being available directly to the dapp, before its own js executes.
amaury1093
added a commit
that referenced
this pull request
Aug 2, 2018
* Use persistent storage for webviews * Update .gitlab-ci.yml enable gitsync * Retrieve dapp token internally * Remove shell_requestNewToken RPC method. The token must be retrieved internally (by importing DappsRequestsStore in Parity UI), this way we can be sure that the appId is coming from a trusted source. The token, along with the appId, are now passed as query string parameters to the dapp (and to subsequent pages during in-dapp navigation) * Use new version of @parity/api stripped of shell_requestNewToken methods that are now unused * Use synchronous blocking methods in preload.js to maximize chances of web3/parity/ethereum objects being available directly to the dapp, before its own js executes.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.