Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added cargo-check-each-crate for macos #40

Closed
Changes from all commits
Commits
Show all changes
39 commits
Select commit Hold shift + click to select a range
49661ff
added cargo-check-each-crate for macos
Bullrich Aug 16, 2024
3004f9a
removed custom image
Bullrich Aug 16, 2024
fb7aabd
removed forklift
Bullrich Aug 16, 2024
4420a60
added required dependency
Bullrich Aug 16, 2024
8a4316c
added concurrency to stop double runs
Bullrich Aug 16, 2024
d9906f9
added another dependency
Bullrich Aug 16, 2024
33ad0ad
added large runnes
Bullrich Aug 16, 2024
07e8d89
added security label
Bullrich Aug 16, 2024
961b20e
removed large runner
Bullrich Aug 16, 2024
a7fb36b
added rust to macos-large
Bullrich Aug 16, 2024
3a48a80
added nightly
Bullrich Aug 16, 2024
863feea
switched to `xlarge`
Bullrich Aug 16, 2024
ebf763e
migrated script to pre-existing workflow
Bullrich Aug 16, 2024
295ed88
added a concurrency job remover
Bullrich Aug 16, 2024
49027d7
removed custom workflow in favor of existing
Bullrich Aug 16, 2024
7ff62ba
added `macOS` runner
Bullrich Aug 20, 2024
a357cdb
added brew command first
Bullrich Aug 20, 2024
67fddcd
added rustup as a brew dependency
Bullrich Aug 20, 2024
3844395
added missing chain
Bullrich Aug 20, 2024
b56d4b6
preinstall rust
Bullrich Aug 20, 2024
381bcc8
added missing `-y` command
Bullrich Aug 20, 2024
e0d7ab2
added nightly install
Bullrich Aug 20, 2024
7a9be7b
added source
Bullrich Aug 20, 2024
dfc3121
test - install rust from brew
Bullrich Aug 20, 2024
c445a74
added generic toolchain
Bullrich Aug 21, 2024
5635134
added rustup init
Bullrich Aug 21, 2024
feedc60
removed old script
Bullrich Aug 21, 2024
902919a
removed `time` command
Bullrich Aug 21, 2024
8582114
manually triggered cargo
Bullrich Aug 21, 2024
173b5f2
renamed job
Bullrich Aug 22, 2024
11e8565
freed some storage
Bullrich Aug 22, 2024
08f0a6a
fixed invalid array name
Bullrich Aug 22, 2024
d7c6f48
added test to run each mac crate individually
Bullrich Aug 22, 2024
9d1b4f0
disabled forklift
Bullrich Aug 22, 2024
fd2ec7e
added step to set up mac image
Bullrich Aug 29, 2024
db29cd5
WIP - removed source command
Bullrich Aug 29, 2024
ef27195
added sourc emethod
Bullrich Aug 29, 2024
103e1d2
renamed the step
Bullrich Aug 29, 2024
f29dc35
removed `if` condition
Bullrich Sep 6, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 25 additions & 1 deletion .github/workflows/check-cargo-check-runtimes.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,12 @@ name: Check Cargo Check Runtimes

on:
pull_request:
types: [ opened, synchronize, reopened, ready_for_review, labeled ]
types: [opened, synchronize, reopened, ready_for_review, labeled]

# This stops the previous job if a new one starts because of a push to the branch
concurrency:
group: ${{ github.ref }}
cancel-in-progress: ${{ github.ref != 'refs/heads/master' }}

# Jobs in this workflow depend on each other, only for limiting peak amount of spawned workers

Expand Down Expand Up @@ -120,6 +124,25 @@ jobs:
with:
root: cumulus/parachains/runtimes/testing

cargo-check-all-crate-macos:
runs-on: macOS
needs: [set-image]
strategy:
fail-fast: false
matrix:
index: [1, 2, 3, 4, 5, 6, 7, 8, 9, 10]
steps:
- uses: actions/checkout@v4
- name: Install dependencies
uses: ./.github/actions/set-up-mac
with:
IMAGE: ${{ needs.set-image.outputs.IMAGE }}
- name: Run cargo check
run: |
source $HOME/.cargo/env
PYTHONUNBUFFERED=x .github/scripts/check-each-crate.py ${{ matrix.index }} ${{ strategy.job-total }} --disable_forklift
# time cargo check --workspace --locked

confirm-required-jobs-passed:
runs-on: ubuntu-latest
name: All check-runtime-* tests passed
Expand All @@ -132,5 +155,6 @@ jobs:
- check-runtime-contracts
- check-runtime-starters
- check-runtime-testing
- cargo-check-all-crate-macos
steps:
- run: echo '### Good job! All the tests passed 🚀' >> $GITHUB_STEP_SUMMARY