Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added dist files to lfs #2

Closed
wants to merge 2 commits into from
Closed

Conversation

Bullrich
Copy link

@Bullrich Bullrich commented Feb 28, 2024

Doing this will stop this files of being tracked as diff but as binary changes, making the PRs cleaner

Summary by CodeRabbit

  • Chores
    • Implemented Git LFS for managing large JavaScript files in the dist directory.
  • Refactor
    • Updated workflow names for consistency in GitHub actions.

Doing this will stop this files of being tracked as diff but as binary changes, making the PRs cleaner
I removed the slash because it appeared as `Check dist/ / Check dist/` in the action name which is a bit weird
Copy link

coderabbitai bot commented Feb 28, 2024

Walkthrough

The recent update includes configuring Git to treat JavaScript files in the dist directory as large files using Git Large File Storage (LFS), and renaming a GitHub workflow for better consistency. These changes aim to improve repository management and workflow clarity.

Changes

File Path Change Summary
.gitattributes Configured to treat .js files in dist as large files using Git LFS.
.github/workflows/check-dist.yml Workflow name updated to "Check dist".

🐇✨
In the land of code and git,
A rabbit hopped and made a fit.
"Let's manage files, both big and small,
And keep our workflows clear for all!"
With a twitch of nose and a leap so high,
Changes were made, beneath the sky.
🌟📂

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 4d81e1f and cc862c9.
Files ignored due to path filters (3)
  • dist/824.index.js is excluded by: !dist/**
  • dist/943.index.js is excluded by: !dist/**
  • dist/index.js is excluded by: !dist/**
Files selected for processing (2)
  • .gitattributes (1 hunks)
  • .github/workflows/check-dist.yml (2 hunks)
Files skipped from review due to trivial changes (1)
  • .github/workflows/check-dist.yml
Additional comments: 1
.gitattributes (1)
  • 1-1: The change to treat JavaScript files in the dist directory as large files using Git LFS is correctly implemented. This should indeed help in making PRs cleaner by reducing the visibility of extensive file diffs for these files.

Please ensure that Git LFS is properly set up in the repository and that contributors are informed about this change, as it requires them to have Git LFS installed locally to correctly handle these files.

@Bullrich Bullrich closed this Feb 29, 2024
@Bullrich Bullrich deleted the lfs/dist branch February 29, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant