-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added dist files to lfs #2
Conversation
Doing this will stop this files of being tracked as diff but as binary changes, making the PRs cleaner
I removed the slash because it appeared as `Check dist/ / Check dist/` in the action name which is a bit weird
WalkthroughThe recent update includes configuring Git to treat JavaScript files in the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files ignored due to path filters (3)
dist/824.index.js
is excluded by:!dist/**
dist/943.index.js
is excluded by:!dist/**
dist/index.js
is excluded by:!dist/**
Files selected for processing (2)
- .gitattributes (1 hunks)
- .github/workflows/check-dist.yml (2 hunks)
Files skipped from review due to trivial changes (1)
- .github/workflows/check-dist.yml
Additional comments: 1
.gitattributes (1)
- 1-1: The change to treat JavaScript files in the
dist
directory as large files using Git LFS is correctly implemented. This should indeed help in making PRs cleaner by reducing the visibility of extensive file diffs for these files.Please ensure that Git LFS is properly set up in the repository and that contributors are informed about this change, as it requires them to have Git LFS installed locally to correctly handle these files.
Doing this will stop this files of being tracked as diff but as binary changes, making the PRs cleaner
Summary by CodeRabbit
dist
directory.