Skip to content
This repository has been archived by the owner on Feb 21, 2022. It is now read-only.

Add Clippy to CI #87

Closed
wants to merge 4 commits into from
Closed

Add Clippy to CI #87

wants to merge 4 commits into from

Conversation

HCastano
Copy link
Contributor

This PR further strays away from the nice world of the substrate-parachain-template by
adding Clippy to the CI pipeline. I think Clippy's knowledge is worth it though.

@HCastano
Copy link
Contributor Author

Looks like the CI image doesn't have Clippy. I've opened paritytech/scripts#341.

@cmichi
Copy link
Contributor

cmichi commented Sep 16, 2021

While I totally agree that clippy is super nice, I fear that this will lead us even further from the ability of keeping the repo easily in sync. I've started #88 so that we can come to a decision on how we want to continue.

@HCastano
Copy link
Contributor Author

We've decided to wait until Cumulus adds Clippy to their CI before adding it to ours.

@HCastano HCastano closed this Sep 17, 2021
@HCastano HCastano deleted the hc-add-clippy-to-ci branch September 17, 2021 15:41
@HCastano HCastano mentioned this pull request Feb 21, 2022
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HCastano @cmichi