Add verify command
#1306
Merged
Add verify command
#1306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should maybe be a warning instead of an error, but I'll need to experiment with this more.
Since releases of `cargo-contract` are now bundled with a `wasm-opt` library we can assume that equal versions of `cargo-contract` contain equal versions of `wasm-opt`.
git update-ref -d MERGE_HEAD
Closed
added 2 commits
August 30, 2023 00:00
ascjones
reviewed
Aug 30, 2023
ascjones
reviewed
Aug 30, 2023
I doubt we will be able to simulate different OS environments, but minor changes in the code should work. |
SkymanOne
commented
Aug 30, 2023
| tracing::debug!("Building contract in {}", project_dir.to_string_lossy()); | ||
| cargo_contract(&project_dir) | ||
| .arg("build") | ||
| .arg("--release") |
There was a problem hiding this comment.
Oddly, without the flag, the cargo contract build produces different wasm binaries even though the crate name and code are identical but places in differnt temp dirs.
ascjones
approved these changes
Aug 31, 2023
5 tasks
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #696
Adds a
cargo contract verify <path to reference contract bundle>command which allows to verify if the given contract code matches the reference bundle.In addition to the previous PR, I have added the support to verify "verifiable" contract. If the contract bundle specify
imagein metadata, then we build the target contract code in the container of the specified image and then verify.This PR also locks the version of
wasm-optcrate which often is the cause of binary mismatch.