Add verify command
#696
Closed
Add verify command
#696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HCastano
force-pushed
the
hc-add-verify-command
branch
from
a8633f5
to
a4aabd4
Compare
ascjones
reviewed
Aug 30, 2022
5 tasks
HCastano
force-pushed
the
hc-add-verify-command
branch
3 times, most recently
from
bf18ec4
to
23a5d82
Compare
ascjones
reviewed
Oct 5, 2022
| found at {}.", | ||
| format!("`{}`", metadata.contract.name).bright_white(), | ||
| format!("{:?}", manifest_path.as_ref()).bright_white()).bright_red() | ||
| ); |
There was a problem hiding this comment.
It would be super useful to print out the SourceCompiler properties of both reference_wasm and built_wasm in case of non matching wasm.
It's useful to know whether they are the same or different for figuring out why verification failed.
And while we are at it, any other properties we have available in Source e.g. SourceLanguage to catch different versions of ink!.
| let fs_wasm = std::fs::read(built_wasm_path)?; | ||
| let built_wasm = SourceWasm::new(fs_wasm); | ||
|
|
||
| if reference_wasm != built_wasm { |
There was a problem hiding this comment.
I believe we should also compare the contract ABI metadata itself? They should be identical too, and if not it might give clues as to what (if anything) is different.
| } else { | ||
| anyhow::bail!( | ||
| "\nThe metadata for the reference contract does not contain a Wasm binary,\n\ | ||
| therefore we are unable to verify the contract." |
There was a problem hiding this comment.
In this case couldn't we just grab the code hash and then compare that?
HCastano
force-pushed
the
hc-add-verify-command
branch
from
23a5d82
to
67e4cc2
Compare
This should maybe be a warning instead of an error, but I'll need to experiment with this more.
HCastano
force-pushed
the
hc-add-verify-command
branch
from
67e4cc2
to
d6db73f
Compare
Since releases of `cargo-contract` are now bundled with a `wasm-opt` library we can assume that equal versions of `cargo-contract` contain equal versions of `wasm-opt`.
Merged
|
Closing in favour of #1306 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will close the
verifysubcommand part of #525.Note that this command does not necessarily work across different operating systems
or CPU architectures (see the discussion in #525 for more details). As such it should
only be used in the context of a well known Docker container à la
srtool.Current built on top of #680 since I want to make sure that we have all the correct info
in the metadata.