Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch registry via cargo instead of own http-implementation #23

Merged
merged 5 commits into from
Oct 27, 2020

Conversation

gnunicorn
Copy link
Contributor

This removes the current code to fetch remote crates directly via http and instead uses the cargo-built-in-system to update the registry. Thus implementing the crates.io crawler policy properly.

fixes #10

@gnunicorn gnunicorn requested a review from Xanewok October 27, 2020 09:41
Copy link
Contributor

@Xanewok Xanewok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a smart way to implement the crawler policy! Looks good, left some comments but we don't have to block on this

src/commands/to_release.rs Outdated Show resolved Hide resolved
src/commands/to_release.rs Outdated Show resolved Hide resolved
@Xanewok
Copy link
Contributor

Xanewok commented Oct 27, 2020

#22 has landed already so this will need a rebase

@gnunicorn gnunicorn requested a review from Xanewok October 27, 2020 10:19
@Xanewok Xanewok merged commit 9cbfd17 into master Oct 27, 2020
@Xanewok
Copy link
Contributor

Xanewok commented Oct 27, 2020

Thanks for addressing my nitpicking 😄

@Xanewok Xanewok deleted the ben-fix-index-caching branch October 27, 2020 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crate should follow crates.io crawler policy
2 participants