Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version bump-breaking cli command #37

Merged
merged 4 commits into from
Mar 2, 2021

Conversation

gnunicorn
Copy link
Contributor

doing smart version updates on semver-breaking-level: bump 0.x to the next minor and x.0 where x >= 1 next major.

In substrate we have 0.8 and 2.0.1 and both need updating to their next breaking level. This command now nicely does that.

@gnunicorn gnunicorn requested a review from Xanewok February 9, 2021 14:36
@gnunicorn gnunicorn changed the title Add version bump-breaking Add version bump-breaking cli command Feb 9, 2021
Copy link
Contributor

@Xanewok Xanewok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left a note wrt Cargo SemVer edge case

src/cli.rs Outdated Show resolved Hide resolved
@gnunicorn gnunicorn merged commit a4dc418 into master Mar 2, 2021
@Xanewok Xanewok deleted the ben-add-bump-breaking-version branch June 14, 2021 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants