Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for multiple labels with the same starting letter on changes.meta #1

Merged
merged 28 commits into from
Feb 15, 2023
Merged

Allow for multiple labels with the same starting letter on changes.meta #1

merged 28 commits into from
Feb 15, 2023

Conversation

joao-paulo-parity
Copy link

@joao-paulo-parity joao-paulo-parity commented Feb 10, 2023 •
edited
Loading

  • Changes the format of changes.meta such that multiple labels with the same starting letter are taken into account (related to Handle non mutually-exclusive labels s3krit/changelogerator#9)
    Check out the new format in the diff of test/test_meta.rb
  • Pulls compute_change_meta and parse_change_label out of Changelogerator so that they can be unit-tested easily
  • Make it possible to run unit tests locally in the absence of $GITHUB_TOKEN

I added some instructions for how to try this out in paritytech/polkadot#6702

@joao-paulo-parity joao-paulo-parity force-pushed the jp/meta branch 3 times, most recently from fa172b0 to 1f5f4ec Compare February 10, 2023 18:28
@joao-paulo-parity joao-paulo-parity changed the title Test CI for upcoming changes Allow for multiple labels with the same starting letter on changes.metah Feb 10, 2023
@joao-paulo-parity joao-paulo-parity changed the title Allow for multiple labels with the same starting letter on changes.metah Allow for multiple labels with the same starting letter on changes.meta Feb 10, 2023
@joao-paulo-parity joao-paulo-parity marked this pull request as ready for review February 10, 2023 18:35
chevdor
chevdor suggested changes Feb 14, 2023
View reviewed changes
Copy link

@chevdor chevdor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some feedback already

test/test_basic.rb Outdated Show resolved Hide resolved
test/test_basic.rb Outdated Show resolved Hide resolved
test/test_basic.rb Outdated Show resolved Hide resolved
lib/changelogerator.rb Outdated Show resolved Hide resolved
@joao-paulo-parity joao-paulo-parity mentioned this pull request Feb 15, 2023
Merged
@chevdor chevdor merged commit 732470e into master Feb 15, 2023
@chevdor chevdor deleted the jp/meta branch February 15, 2023 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chevdor chevdor chevdor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joao-paulo-parity @chevdor