Co #5064: Use runtime dependant weights #1076
Conversation
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
ggwpez
added
A3-inprogress
B0-silent
|
bot rebase |
|
Rebasing |
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
|
Waiting for commit status. |
|
Merge cancelled due to error. Error: Checks failed for 9f9350d |
|
bot rebase |
|
Rebasing |
| @@ -58,7 +58,7 @@ kusama-runtime-constants = { git = "https://github.com/paritytech/polkadot", def | |||
| pallet-xcm = { git = "https://github.com/paritytech/polkadot", default-features = false, branch = "master" } | |||
| polkadot-core-primitives = { git = "https://github.com/paritytech/polkadot", default-features = false, branch = "master" } | |||
| polkadot-parachain = { git = "https://github.com/paritytech/polkadot", default-features = false, branch = "master" } | |||
| polkadot-runtime-common = { git = "https://github.com/paritytech/polkadot", default-features = false, branch = "master" } | |||
| polkadot-runtime = { git = "https://github.com/paritytech/polkadot", default-features = false, branch = "master" } | |||
There was a problem hiding this comment.
Wait wait. Sorry that I'm late to the party. But, this is canvas-kusama. Why did you even removed the runtime-common?
Because the RocksDbWeight is now different per runtime?
It is really bad that include here the entire runtime into another runtime. Especially as RocksDbWeight should be defined here in each runtime and should not be taken from Polkadot.
There was a problem hiding this comment.
The polkadot-runtime-common does not contain the RocksDbWeight now anymore, I did not think that it is a bad idea to include one runtime into another.
So I should rather also copy the weights into all the parachain configs as well? Makes much more sense when I write it out like this 🤦
There was a problem hiding this comment.
I mean you now automatically generate this weight? So, this weight could also be generated for the parachains?
There was a problem hiding this comment.
Theoretically it should work. I just never tried to run the collators myself.
Also not sure if their CLI uses the command yet.
So I fixed the parachain weights in paritytech/polkadot#5091 and #1081, but I'm a bit tired now, so hope this all makes sense.
There was a problem hiding this comment.
Yeah that looks like a good start. However, every substrate based chain should generate these weights on their own. The same applies to all the other parachains. So, you should make sure that they also can generate these weights. It makes no sense to only create them for polkadot.
There was a problem hiding this comment.
Yes sure that was the long term plan. For now this just fixes the dependency on the Polkadot runtime.
In the future the Storage and Block/Extrinsic weights should all be generated by the new bench bot.
Can we merge the mentioned MRs or do you need something else for that? I was under the impression that this should be fixes ASAP.
There was a problem hiding this comment.
Okay, yeah I will review them now :)
Companion for paritytech/polkadot#5064
polkadot-runtimeinstead ofpolkadot-runtime-commonsince the weights are now not common anymore but depend on the runtime.