This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Statemint runtimes to accept sufficient assets as xcm fee payment #1278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t-runtimes-to-accept-sufficient-assets
girazoki
changed the title
girazoki
changed the title
We are working on a dir restructure that will include a folder for all asset parachain runtimes. I think we could probably add a |
hbulgarini
added
the
T7-system_parachains
|
Thanks for the PR @girazoki ! could you please fix the conflicting files? as Joe mentioned the dir restructure might originates the conflicts described. |
|
sure! |
kianenigma
approved these changes
Aug 2, 2022
…s-to-accept-sufficient-assets
…t-runtimes-to-accept-sufficient-assets
…' of https://github.com/girazoki/cumulus into girazoki-statemint-runtimes-to-accept-sufficient-assets
…t-runtimes-to-accept-sufficient-assets
|
bot merge |
2 tasks
This was referenced Oct 12, 2022
5 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #1247
It adds a new trader
TakeFirstAssetTrader, which takes the first asset and tries to charge xcm execution on such asset. If such asset in a sufficient asset inpallet-assets, then thefee(corresponding to how much it would cost in the native token) is converted to anasset_fee(corresponding to how much it would cost in the specified asset) based on the difference on the existential deposits.Charged fee is for now given to the block author. I am open to suggestions on this
Missing tests, I am unsure where to add these tests. Open to suggestions on this too