Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

[benchmarks] Update weights for assets #1784

Closed
wants to merge 1 commit into from
Closed

[benchmarks] Update weights for assets #1784

wants to merge 1 commit into from

Conversation

paritytech-ci
Copy link
Contributor

This PR is generated automatically by CI. (Once merged please backport to master and node release branch.)

@ggwpez
Copy link
Member

ggwpez commented Oct 19, 2022 •
edited
Loading

Whoever maintains this could add a link to https://weights.tasty.limo/compare-mr?repo=cumulus in the description. Specific link for this MR (will expire once the branch is deleted).

@EgorPopelyaev EgorPopelyaev added B0-silent Changes should not be mentioned in any release notes T9-release This PR/Issue is related to topics touching the release notes. A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Oct 20, 2022
@EgorPopelyaev EgorPopelyaev requested review from a team, muharem and ruseinov October 20, 2022 08:59
@EgorPopelyaev EgorPopelyaev mentioned this pull request Oct 20, 2022
Closed
13 tasks
@chevdor chevdor changed the title [benchmarks] Update weights for statemine/t [benchmarks] Update weights for assets Oct 20, 2022
coderobe
coderobe reviewed Oct 20, 2022
View reviewed changes
parachains/runtimes/assets/statemine/src/weights/pallet_assets.rs
.saturating_add(T::DbWeight::get().reads(10505 as u64))
.saturating_add(T::DbWeight::get().reads((1 as u64).saturating_mul(c as u64)))
.saturating_add(T::DbWeight::get().reads((1 as u64).saturating_mul(s as u64)))
.saturating_add(T::DbWeight::get().writes(10502 as u64))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

odd change?

parachains/runtimes/assets/statemine/src/weights/pallet_assets.rs
.saturating_add(Weight::from_ref_time(10_684_701 as u64).saturating_mul(c as u64))
// Standard Error: 138_450
.saturating_add(Weight::from_ref_time(11_056_248 as u64).saturating_mul(s as u64))
.saturating_add(T::DbWeight::get().reads(10505 as u64))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

odd change?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EgorPopelyaev
The numbers for destroy are wrong, and I do not see any changes for destroy itself and its benches between 9300 and prev version.
Probably we need to rerun.

@ggwpez have you seen anything like this?

Copy link
Member

@ggwpez ggwpez Oct 20, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fuck, this is also happens when updating Substrate. Hopefully fixed by paritytech/substrate#12482, I am investigating.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay it is merged in Substrate.

EgorPopelyaev
EgorPopelyaev reviewed Oct 20, 2022
View reviewed changes
Copy link
Contributor

@EgorPopelyaev EgorPopelyaev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There some big jumps from 0 to billion values

parachains/runtimes/assets/statemine/src/weights/pallet_uniques.rs
.saturating_add(Weight::from_ref_time(1_727_000 as u64).saturating_mul(m as u64))
// Standard Error: 13_000
.saturating_add(Weight::from_ref_time(1_664_000 as u64).saturating_mul(a as u64))
Weight::from_ref_time(2_473_812_000 as u64)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 -> 71_841_919_000

parachains/runtimes/assets/statemint/src/weights/pallet_uniques.rs
.saturating_add(Weight::from_ref_time(1_703_000 as u64).saturating_mul(m as u64))
// Standard Error: 14_000
.saturating_add(Weight::from_ref_time(1_599_000 as u64).saturating_mul(a as u64))
Weight::from_ref_time(2_476_377_000 as u64)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 -> 2_476_377_000

parachains/runtimes/assets/westmint/src/weights/pallet_assets.rs
.saturating_add(T::DbWeight::get().writes((2 as u64).saturating_mul(s as u64)))
.saturating_add(T::DbWeight::get().writes((1 as u64).saturating_mul(a as u64)))
fn destroy(c: u32, s: u32, _a: u32, ) -> Weight {
Weight::from_ref_time(75_026_861_000 as u64)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 -> 75_026_861_000

parachains/runtimes/assets/westmint/src/weights/pallet_uniques.rs
.saturating_add(Weight::from_ref_time(1_796_000 as u64).saturating_mul(m as u64))
// Standard Error: 13_000
.saturating_add(Weight::from_ref_time(1_646_000 as u64).saturating_mul(a as u64))
Weight::from_ref_time(2_475_972_000 as u64)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 -> 2_475_972_000

@muharem
Copy link
Contributor

muharem commented Oct 20, 2022

/cmd queue -c bench-bot $ runtime statemint-dev pallet_assets::destroy

@command-bot
Copy link

command-bot bot commented Oct 20, 2022 •
edited
Loading

@muharem https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/1972148 was started for your command "$PIPELINE_SCRIPTS_DIR/bench-bot.sh" runtime statemint-dev pallet_assets::destroy. Check out https://gitlab.parity.io/parity/mirrors/cumulus/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment /cmd cancel 24-1422b641-48b4-43c3-9a64-cb9c846ee260 to cancel this command or /cmd cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Oct 20, 2022

@muharem Command "$PIPELINE_SCRIPTS_DIR/bench-bot.sh" runtime statemint-dev pallet_assets::destroy has finished. Result: https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/1972148 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/1972148/artifacts/download.

@muharem
Copy link
Contributor

muharem commented Oct 20, 2022

/cmd queue -c bench-bot $ pallet statemint-dev pallet_assets::destroy

@command-bot
Copy link

command-bot bot commented Oct 20, 2022 •
edited
Loading

@muharem https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/1972150 was started for your command "$PIPELINE_SCRIPTS_DIR/bench-bot.sh" pallet statemint-dev pallet_assets::destroy. Check out https://gitlab.parity.io/parity/mirrors/cumulus/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment /cmd cancel 25-043cda83-48fa-48f5-ad0a-5564d9c4446a to cancel this command or /cmd cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Oct 20, 2022

@muharem Command "$PIPELINE_SCRIPTS_DIR/bench-bot.sh" pallet statemint-dev pallet_assets::destroy has finished. Result: https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/1972150 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/1972150/artifacts/download.

@muharem
Copy link
Contributor

muharem commented Oct 20, 2022

/cmd queue -c bench-bot $ pallet statemint-dev pallet_assets

@command-bot
Copy link

command-bot bot commented Oct 20, 2022 •
edited
Loading

@muharem https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/1972175 was started for your command "$PIPELINE_SCRIPTS_DIR/bench-bot.sh" pallet statemint-dev pallet_assets. Check out https://gitlab.parity.io/parity/mirrors/cumulus/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment /cmd cancel 26-67e44b79-79e7-43b9-9db5-2ff63ae8497f to cancel this command or /cmd cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Oct 20, 2022

@muharem Command "$PIPELINE_SCRIPTS_DIR/bench-bot.sh" pallet statemint-dev pallet_assets has finished. Result: https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/1972175 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/1972175/artifacts/download.

This was referenced Oct 20, 2022
Closed
Closed
@bkchr bkchr closed this Dec 30, 2022
@bkchr bkchr deleted the weights-statemint-release-parachains-v9300-1666214790 branch December 30, 2022 22:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@EgorPopelyaev EgorPopelyaev EgorPopelyaev left review comments

@coderobe coderobe coderobe left review comments

@ggwpez ggwpez ggwpez left review comments

@chevdor chevdor chevdor approved these changes

@muharem muharem Awaiting requested review from muharem

@ruseinov ruseinov Awaiting requested review from ruseinov

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit T9-release This PR/Issue is related to topics touching the release notes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@paritytech-ci @ggwpez @muharem @chevdor @EgorPopelyaev @coderobe @bkchr